[8u] RFR: 8159690: [TESTBUG] Mark headful tests with @key headful.

Jonathan Dowland jdowland at redhat.com
Mon Nov 2 16:17:31 UTC 2020


Hi Paul,

Thanks for the comments!

On Thu, Oct 29, 2020 at 03:37:29PM +0000, Hohensee, Paul wrote:
> Hi, Jonathan, just a couple of comments.
> 
> Looks like you're missing a file in your patch, namely
> 
> test/java/awt/image/DrawImage/IncorrectUnmanagedImageSourceOffset.java

Your'e right. This is concerning (to me) because it points at a flaw in
my methodology in producing the patch. However, once we've finished the
backporting of the listed patches from the classpath URI, I (or someone)
will have to look at this one afresh.

> Also, the following changeset header should work. It conforms to the
> guideline that the original User be preserved.

I wasn't aware of that nuance, I'll bear that in mind for future
patches. Thanks!


-- 
���� Jonathan Dowland <jdowland at redhat.com>
Senior Software Engineer, OpenJDK, Red Hat



More information about the jdk8u-dev mailing list