8160974: [TESTBUG] Mark more headful tests with @key headful.

[Hohensee, Paul]

You're right, it can't really be reviewed until all the other 3077-related patches have been applied. Andrew, would you take a look at those please?

Thanks,
Paul

On 11/17/20, 2:36 AM, "Volker Simonis" <volker.simonis at gmail.com> wrote:

    Sorry, but I'm a little lost and have no idea how I could review this?

    If I import this patch into the current 8u-dev it will be applied to
    243 files but at the same time it won't find 285 files which it wants
    to change and it gets rejected hunks on four files. It seems like this
    backport has a whole lot of dependencies and unless we have not
    downported them all it will be hard to review this one.

    E.g. I have situations like this:

    Original patch:

    diff -r ce8600f2919e -r fe58d505fffd
    test/java/awt/Focus/MouseClickRequestFocusRaceTest/MouseClickRequestFocusRaceTest.java
    --- a/test/java/awt/Focus/MouseClickRequestFocusRaceTest/MouseClickRequestFocusRaceTest.java
       Wed Jul 20 14:17:41 2016 +0530
    +++ b/test/java/awt/Focus/MouseClickRequestFocusRaceTest/MouseClickRequestFocusRaceTest.java
       Thu Jul 07 16:21:45 2016 +0200
    @@ -42,6 +42,7 @@

     /**
      * @test
    + * @key headful
      * @bug 5028014
      * @summary Focus request & mouse click being performed nearly synchronously
      *          shouldn't break the focus subsystem

    which differs from the 8u version:

    --- old/test/java/awt/Focus/MouseClickRequestFocusRaceTest/MouseClickRequestFocusRaceTest.java
       2020-11-16 01:51:34.994431565 +0000
    +++ new/test/java/awt/Focus/MouseClickRequestFocusRaceTest/MouseClickRequestFocusRaceTest.java
       2020-11-16 01:51:34.866428340 +0000
    @@ -23,6 +23,7 @@

     /*
       test
    +  @key       headful
       @bug       5028014
       @summary   Focus request & mouse click performed nearly
    synchronously shouldn't lead to a focus race.
       @author    anton.tarasov at sun.com: area=awt-focus

    But there's currently no
    "test/java/awt/Focus/MouseClickRequestFocusRaceTest/MouseClickRequestFocusRaceTest.java"
    in 8u-dev so I have no idea against what version of 8u-dev with which
    changes applied this patch was created.

    On Mon, Nov 16, 2020 at 3:29 AM Hohensee, Paul <hohensee at amazon.com> wrote:
    >
    > Would help if I included JBS info, etc.
    >
    > JBS issue: https://bugs.openjdk.java.net/browse/JDK-8160974
    > Original patch: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/fe58d505fffd
    > Webrev: http://cr.openjdk.java.net/~phh/8160974/webrev.8u.jdk.00/
    >
    > The webrev is against all 3077 patches including that for 8159690, but not including 8039081, which latter will be pushed after this one.
    >
    > Paul
    >
    > On 11/15/20, 5:32 PM, "jdk8u-dev on behalf of Hohensee, Paul" <jdk8u-dev-retn at openjdk.java.net on behalf of hohensee at amazon.com> wrote:
    >
    >     Please review this backport, which is part of the patch tail for https://icedtea.classpath.org/bugzilla/show_bug.cgi?id=3077.
    >
    >     This is a replacement patch for the one for which a review was requested in https://mail.openjdk.java.net/pipermail/jdk8u-dev/2020-October/012773.html.
    >
    >     As noted in a comment on the JBS issue, there are 59 tests that were in the original patch that are not present in 8u.
    >
    >     The patch is not clean because the 59 tests are omitted, and because of various context differences. The only substantive change is the addition of @headful, which doesn’t affect running any of the tests.
    >
    >     Thanks,
    >     Paul
    >
    >