RFR: 8063107: Change open swing regression tests to avoid sun.awt.SunToolkit.realSync, part 2

[Hohensee, Paul]

Thanks, Volker. Those dependencies will go in before this patch does.

Paul

On 11/17/20, 5:57 AM, "Volker Simonis" <volker.simonis at gmail.com> wrote:

    Hi Paul,

    this looks good except of two issues:

    - your patch contains changes for the file
    "test/javax/swing/JRadioButton/8041561/bug8041561.java" which isn't
    currently present in 8u-dev. Either the
    dependency which provides this file should be downported or the
    changes to "test/javax/swing/JRadioButton/8041561/bug8041561.java"
    should be removed from the patch.
    - your patch doesn't include the changes to
    "test/javax/swing/JComponent/6683775/bug6683775.java" which were part
    of the original change. It seems like it were only whitespace changes
    but nevertheless interesting why they are omitted.

    Otherwise looks good.

    Thank you and best regards,
    Volker

    On Fri, Nov 6, 2020 at 12:24 AM Hohensee, Paul <hohensee at amazon.com> wrote:
    >
    > Please review this test backport. It’s part of the sequence described by https://mail.openjdk.java.net/pipermail/jdk8u-dev/2020-November/012959.html.
    >
    > Original JBS issue: https://bugs.openjdk.java.net/browse/JDK-8063107
    > Original commit: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/4ef86895869c
    > IcedTea8 commit: http://icedtea.classpath.org//hg/icedtea8-forest/jdk?cmd=changeset;node=006ecd93bed6<http://icedtea.classpath.org/hg/icedtea8-forest/jdk?cmd=changeset;node=006ecd93bed6>
    > Webrev: http://cr.openjdk.java.net/~phh/8063107/webrev.8u.jdk.00/
    >
    > The webrev is identical to the IcedTea8 commit.
    >
    >
    > In jdk/test/javax/swing/JComponent/8002077/bug8002077.java:
    >
    > The first hunk removes the import of java.awt.Toolkit in addition to sun.awt.SunToolkit.
    >
    > The second and third hunks are merged. Previous patches backported from jdk9 modified the jdk8u file to be the almost the same as the one in 9, so the change in this hunk just replaces occurrences of toolkit.realSync with robot.waitForIdle.
    >
    >
    >
    > Thanks,
    >
    > Paul
    >
    >
    >