[8u][RFR][1/3] 8145260: Bring j.u.z.ZipFile's native implementation to Java to remove the expensive jni cost and mmap crash risk

[Andrew Hughes]

On 20:14 Thu 12 Nov     , Taylor, Ben wrote:
> Hello,
> 
> This backport has been suggested previously[1]
> This backport is the first of 3, and should be followed by 8157069[2] and 6233323[3]
> for correctness and performance.
> 
> The patch was modified to preserve the use of ensuretrailingslash
> in ZipFile.getEntry(). This property is not present in jdk 9+.
> Its behavior is described in detail by 8185136: Release Note:
> java.util.zip.ZipFile.getEntry() now always returns the ZipEntry
> instance with a '/' ended entry name for directory entry[4].
> 
> This patch includes a new test, TestZipFile.java, and an update
> to TestZipError.java. Both tests pass.
> 
> https://bugs.openjdk.java.net/browse/JDK-8145260
> http://cr.openjdk.java.net/~cverghese/webrevs/8145260/webrev/
> 
> Thanks,
> --Ben
> 
> [1] https://bugs.openjdk.java.net/browse/JDK-8146693
> [2] https://bugs.openjdk.java.net/browse/JDK-8157069
> [3] https://bugs.openjdk.java.net/browse/JDK-6233323
> [4] https://bugs.openjdk.java.net/browse/JDK-8185136

We considered backporting this earlier in the year (it appeared as a
dependency for two other ZIP fixes) and decided it wasn't worth the
risk.

Is this a request for the fix itself or as a dependency for some other
future fix?

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222