[8u] RFR: 8249183: JVM crash in "AwtFrame::WmSize" method
Hohensee, Paul
hohensee at amazon.com
Tue Nov 24 20:33:00 UTC 2020
All five files need a copyright date update to 2020. Other than that, lgtm.
Thanks,
Paul
On 9/29/20, 1:33 PM, "jdk8u-dev on behalf of Alex Kashchenko" <jdk8u-dev-retn at openjdk.java.net on behalf of akashche at redhat.com> wrote:
Hi,
Please review the backport of JDK-8249183 to 8u:
Bug: https://bugs.openjdk.java.net/browse/JDK-8249183
Original change: https://hg.openjdk.java.net/jdk/jdk/rev/9f529b04be26
8u webrev: https://cr.openjdk.java.net/~akasko/jdk8u/8249183/webrev.00/
Patch doesn't apply cleanly to 8u, besides paths changes, two hunks
with import changes in WWindowPeer.java [1] are omitted. These imports
were changed by JDK-8221823 [2], these changes to imports are not
necessary in 8u because wildcard imports are used there in 8u.
Original patch was added in 16, its backport was pushed to 15u and is
currently waiting for approval for 11u (both applied cleanly).
Testing: checked that "CrashOnMinimizingDialogTest.zip" test (attached
to the issue) crashes on unpatched jdk and passes with the patch
applied, ran jck:api/java_awt .
[1] https://hg.openjdk.java.net/jdk/jdk/rev/9f529b04be26#l1.3
[2] https://hg.openjdk.java.net/jdk/jdk/rev/19adbbca4307#l1.16
--
-Alex
More information about the jdk8u-dev
mailing list