[8u] RFR 8205507: jdk/javax/xml/crypto/dsig/GenerationTests.java timed out

[Hohensee, Paul]

8177334 has been backported to 8u, so I took the liberty of making a new webrev for the 8205507 backport. Please review.

http://cr.openjdk.java.net/~phh/8205507/webrev.8u.00/

The patch was indeed almost clean: the first and fifth hunks needed only context changes for the @bug number and the introductory line respectively.

Thanks,
Paul

On 8/23/19, 4:36 AM, "jdk8u-dev on behalf of Andrew Hughes" <jdk8u-dev-bounces at openjdk.java.net on behalf of gnu.andrew at redhat.com> wrote:

    On Mon, 5 Aug 2019 at 23:26, Martin Balao <mbalao at redhat.com> wrote:
    >
    > Hi,
    >
    > I'd like to have a review for the jdk8u backport of JDK-8205507 [1]:
    >
    >  *
    > http://cr.openjdk.java.net/~mbalao/webrevs/8205507/8205507.webrev.jdk8u.jdk.00/
    >
    > Minor changes in GenerationTests::getCachedKeys function were required.
    >
    > Testing: javax/xml/crypto/dsig/GenerationTests.java passed.
    >
    > Thanks,
    > Martin.-
    >
    > --
    > [1] - https://bugs.openjdk.java.net/browse/JDK-8205507

    It would help the review process,in such cases,if you could elaborate
    on the 'minor changes' required and why.

    Comparing the two changesets, it seems the case statement gets removed
    in 11u by JDK-8177334. As that change is also marked for Oracle 8u231,
    it doesn't make sense to me to backport this change first and create
    more work for the backporting of 8177334. Once 8177334 is in, this
    should become close to a clean backport.
    -- 
    Andrew :)

    Senior Free Java Software Engineer
    Red Hat, Inc. (http://www.redhat.com)

    Web Site: http://fuseyism.com
    Twitter: https://twitter.com/gnu_andrew_java
    PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
    Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222