[8u] RFR 8047765: Generate blacklist.certs in build
Hohensee, Paul
hohensee at amazon.com
Wed Nov 25 01:20:43 UTC 2020
That looks better. Lgtm.
Thanks,
Paul
On 7/14/20, 11:15 AM, "jdk8u-dev on behalf of Zhengyu Gu" <jdk8u-dev-retn at openjdk.java.net on behalf of zgu at redhat.com> wrote:
Hi Andrew,
>
> I was looking at this one when we added keystore generation, but decided
> the backport wasn't worth the trouble. No real reason not to do it though.
>
> It shouldn't be a removal of those files, but a move; only
> src/share/lib/security/blacklisted.certs is actually removed.
>
> Is it possible to attach a 'hg diff --git' of this patch to check this
> is correct? The webrev version doesn't do that.I downloaded patch from
http://hg.openjdk.java.net/jdk9/jdk9/jdk/raw-rev/fd7630919a9d.
Apparently, it converted renaming to deleting and adding.
Exported the patch from jdk9u directly.
Updated: http://cr.openjdk.java.net/~zgu/JDK-8047765-8u/webrev.01/
>
> $ grep 'rename' 8047765.11u
> rename from jdk/src/share/lib/security/blacklisted.certs.pem
> rename to jdk/make/data/blacklistedcertsconverter/blacklisted.certs.pem
> rename from jdk/src/share/lib/security/BlacklistedCertsConverter.java
> rename to
> jdk/make/src/classes/build/tools/blacklistedcertsconverter/BlacklistedCertsConverter.java
[zgu at localhost patches]$ grep 'rename' JDK-8047765-blacklist_certs
rename from src/share/lib/security/blacklisted.certs.pem
rename to make/data/blacklistedcertsconverter/blacklisted.certs.pem
rename from src/share/lib/security/BlacklistedCertsConverter.java
rename to
make/src/classes/build/tools/blacklistedcertsconverter/BlacklistedCertsConverter.java
Thanks,
-Zhengyu
>
> Thanks,
>
More information about the jdk8u-dev
mailing list