[8u] RFR: 8242480: Negative value may be returned by getFreeSwapSpaceSize() in the docker

[Andrew Hughes]

On 15:37 Mon 02 Nov     , Severin Gehwolf wrote:
> Hi,
> 
> Please review this backport for Oracle JDK parity. The JDK 11 patch did
> apply cleanly after JDK-8221710 which is in the approval queue, but the
> test was not working and needed some fixes:
> 
>  * Common.java in OpenJDK 8u uses unified logging VM args. Used
>    -XX:+UnlockDiagnosticVMOptions -XX:+PrintContainerInfo instead.
>  * The test library location needed updates
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8242480
> webrev: https://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8242480/jdk8/01/webrev/
> 
> Testing: Regression test on Linux x86_64. Failed before, passes after.
> 
> Thoughts?
> 
> Thanks,
> Severin
> 

I think the Common.java change should go in under a separate bug. It's not
an issue with this fix, but a bug introduced by 8223147: "JFR Backport".

It's also worth noting that your changes are backed up by the duplicate copy
of Common.java found in the HotSpot repository [0].

If these tests are HotSpot-specific, should they not be in the HotSpot
repository?

[0] https://hg.openjdk.java.net/jdk8u/jdk8u/hotspot/file/83661fdee9f0/test/testlibrary/com/oracle/java/testlibrary/Common.java#l67

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222