[8u] RFF:8256671: Incorrect assignment operator used in guarantee() in genCollectedHeap

linzang(臧琳) linzang at tencent.com
Wed Nov 25 07:45:30 UTC 2020


> OK, thanks. Looks like the buggy code was gone by the time of JDK 9,
> so there's no need for a backport here.

Thanks Andrew!
Sorry that I missed your reply.
Do I need to get more review about this webrev? Or may I ask your help to push it?   

BRs,
Lin

On 2020/11/20, 12:05 AM, "linzang(臧琳)" <linzang at tencent.com> wrote:

    Dear All, 
         May I ask your help to review this 1 line change in genCollectedHeap.cpp? 
         Bug: https://bugs.openjdk.java.net/browse/JDK-8256671
         Webrev: http://cr.openjdk.java.net/~lzang/8256671/

    The diff: 
    --- old/src/share/vm/memory/genCollectedHeap.cpp	2020-11-19 22:59:45.332013050 +0800
    +++ new/src/share/vm/memory/genCollectedHeap.cpp	2020-11-19 22:59:45.268013049 +0800
    @@ -1181,7 +1181,7 @@


     void GenCollectedHeap::prepare_for_compaction() {
    -  guarantee(_n_gens = 2, "Wrong number of generations");
    +  guarantee(_n_gens == 2, "Wrong number of generations");
       Generation* old_gen = _gens[1];
       // Start by compacting into same gen.
       CompactPoint cp(old_gen);


    Thanks!
    Lin




More information about the jdk8u-dev mailing list