[8u] RFR 8205507: jdk/javax/xml/crypto/dsig/GenerationTests.java timed out

Hohensee, Paul hohensee at amazon.com
Wed Nov 25 14:30:27 UTC 2020


Thanks for the review, Andrew. New webrev

http://cr.openjdk.java.net/~phh/8205507/webrev.8u.02/

I'll tag the issue.

Paul

On 11/24/20, 10:12 PM, "Andrew Hughes" <gnu.andrew at redhat.com> wrote:

    On 00:07 Wed 25 Nov     , Hohensee, Paul wrote:
    > 8177334 has been backported to 8u, so I took the liberty of making a new webrev for the 8205507 backport. Please review.
    > 
    > http://cr.openjdk.java.net/~phh/8205507/webrev.8u.00/
    > 
    > The patch was indeed almost clean: the first and fifth hunks needed only context changes for the @bug number and the introductory line respectively.
    > 
    > Thanks,
    > Paul
    >

    Thanks for reviving this one.

    The ascending order of the bug IDs should be maintained as it is in 11u:

    i.e.

    + * 8038349 8046724 8074784 8079693 8177334 8210736 8217878 8205507

    rather than:

    + * 8038349 8046724 8074784 8079693 8177334 8205507 8210736 8217878

    Otherwise looks fine.

    Thanks,
    -- 
    Andrew :)

    Senior Free Java Software Engineer
    OpenJDK Package Owner
    Red Hat, Inc. (http://www.redhat.com)

    PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
    Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222



More information about the jdk8u-dev mailing list