[8u] RFR: 8250984: Memory Docker tests fail on some Linux kernels w/o cgroupv1 swap limit capabilities
Severin Gehwolf
sgehwolf at redhat.com
Thu Nov 26 10:38:45 UTC 2020
On Mon, 2020-11-23 at 21:50 +0000, Hohensee, Paul wrote:
> Nit: the original patch for TestMemoryAwareness.java has a blank line between the two try-catch blocks that isn't present in your patch.
OK. Fixed locally. I'll include this in the push once I've got
approval.
> Otherwise, lgtm, and no need for another webrev.
Thanks for the review, Paul!
Cheers,
Severin
> On 11/23/20, 9:40 AM, "jdk8u-dev on behalf of Severin Gehwolf" <jdk8u-dev-retn at openjdk.java.net on behalf of sgehwolf at redhat.com> wrote:
>
> Hi,
>
> Please review this container fix for OpenJDK 8u. It fixes an issue for
> systems which don't have swap accounting turned on. This is an Oracle
> JDK parity fix too. The differences to the JDK 11 patch are minor:
>
> * Split of the patches between hotspot and jdk repositories in JDK 8
> * New OutputAnalyzer import in TestMemoryAwareness.java. Introduced
> with JDK-8229182 in JDK 11 currently not slated for backport in 8.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8250984
> webrev: https://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8250984/jdk8/01/
>
> Testing: Container tests on Linux x86_64 cgroup v1 with swappaccount=0.
> Fails before, passes after.
>
> Thoughts?
>
> Thanks,
> Severin
>
>
More information about the jdk8u-dev
mailing list