[8u] RFR: 8150204: (fs) Enhance java/nio/file/Files/probeContentType/Basic.java debugging output

Hohensee, Paul hohensee at amazon.com
Thu Nov 26 13:54:30 UTC 2020


Lgtm. :)

Thanks,
Paul

On 11/26/20, 2:44 AM, "Alex Kashchenko" <akashche at redhat.com> wrote:

    On 11/25/20, Hohensee, Paul <hohensee at amazon.com> wrote:
    > This looks fine, except that the patch should be based on the result of "hg
    > export --git".

    Thanks for the review! The same patch exported with "webrev -c" (with
    original metadata):

    https://cr.openjdk.java.net/~akasko/jdk8u/8150204/webrev.01/

    >
    > Thanks,
    > Paul
    >
    > On 6/30/20, 5:15 AM, "jdk8u-dev on behalf of Alex Kashchenko"
    > <jdk8u-dev-retn at openjdk.java.net on behalf of akashche at redhat.com> wrote:
    >
    >     The message from this sender included one or more files
    >     which could not be scanned for virus detection; do not
    >     open these files unless you are certain of the sender's intent.
    >
    >     ----------------------------------------------------------------------
    >     Hi,
    >
    >     Please review the backport of JDK-8150204 to 8u:
    >
    >     Bug: https://bugs.openjdk.java.net/browse/JDK-8150204
    >
    >     Related thread:
    >     https://mail.openjdk.java.net/pipermail/jdk8u-dev/2020-June/012055.html
    >
    >     9 change: https://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/e4af8119eba4
    >
    >     8u webrev: https://cr.openjdk.java.net/~akasko/jdk8u/8150204/webrev.00/
    >
    >     This change is a prerequisite to JDK-8146215, only test code is
    > changed,
    >     patch requires adjustments for 8u because it includes changes from
    >     JDK-8129632 that is not in 8u, macOS-specific part is omitted.
    >
    >     --
    >     -Alex
    >
    >
    >


    --
    -Alex




More information about the jdk8u-dev mailing list