回复: JDK-8257039: GenericTaskQueue destructor is incorrect

[wattsun(孙宇)]

Tanks Lin, sorry for my later reply.

After investigating, jdk9 and later version has refactored ArrayAllocator implementation, so this issue should exist on only 8u.

Thanks
watt

----------------------------------------------------------------------------------------
Hi Watt, 

> diff -r 83661fdee9f0 src/share/vm/utilities/taskqueue.hpp
>
> --- a/src/share/vm/utilities/taskqueue.hpp      Wed Nov 18 06:55:35 2020 +0000
>
> +++ b/src/share/vm/utilities/taskqueue.hpp      Thu Nov 26 11:59:11 2020 +0800
>
> @@ -431,7 +431,6 @@
> 
> template<class E, MEMFLAGS F, unsigned int N>
> 
> GenericTaskQueue<E, F, N>::~GenericTaskQueue() {
> 
> -  FREE_C_HEAP_ARRAY(E, _elems, F);
> 
> }

      I am not a reviewer, just made a quick check that the tip also has the same code in ~GenericTaskQueueSet(), so maybe you could check and fix it first, and then make a backport.

BRs,
Lin