RFR Backport: 8078024: javac, several incorporation steps are silently failing when an error should be reported

[Peter Zhelezniakov]

Hi Paul,
Thank you for the review. Sorry I've missed the metadata part completely. This time I've checked it is preserved in the patch.
New webrev: http://cr.openjdk.java.net/~alexsch/peterz/8078024/webrev.02/
Thanks,
Peter

On Nov 25 2020, at 4:37 am, Hohensee, Paul <hohensee at amazon.com> wrote:
> Looks good, but please preserve the original metadata. Use an importable patch generated using "hg export --git -r 2890" on the jdk9u/langtools repo http://hg.openjdk.java.net/jdk-updates/jdk9u/langtools/ as the basis for your patch. Modify it as you've done in your webrev, import it using "hg import", then use "webrev -c 8078024" to generate a webrev.
>
> Thanks,
> Paul
>
> On 11/16/20, 8:16 AM, "jdk8u-dev on behalf of Peter Zhelezniakov" <jdk8u-dev-retn at openjdk.java.net on behalf of peter.zhelezniakov at bell-sw.com> wrote:
> Hi all,
> Can I get a review on this one please? This is backport of a fix made for JDK9. The src/ part of the original patch applies cleanly, in the test/ part some contextual changes were necessary. I've also updated a copyright.
> Bug: https://bugs.openjdk.java.net/browse/JDK-8078024
> Webrev: http://cr.openjdk.java.net/~alexsch/peterz/8078024
> This fix improves compilation situation for one of our clients while their project compiles with JDK11 but fails to compile with JDK8.
> Thanks!
>