[8u] RFR: 8242480: Negative value may be returned by getFreeSwapSpaceSize() in the docker

[Andrew Hughes]

On 14:25 Wed 25 Nov     , Severin Gehwolf wrote:
> Hi Andrew,
> 

snip...

> > 
> > I think the Common.java change should go in under a separate bug. It's not
> > an issue with this fix, but a bug introduced by 8223147: "JFR Backport".
> 
> I'm not disagreeing, but practical matters need to be taken into
> account. It's not worth the extra overhead. Separate bug, separate
> approval/review. So my preference would be to keep it as part of this
> fix as it seems to be the first test which makes use of Common. Without
> it, the test fails. We shouldn't delay this fix any further.
>

You could have filed a bug and posted a webrev in only a little more time
than it took to write this paragraph. It would then have been reviewed and
approved by now.

> > It's also worth noting that your changes are backed up by the duplicate copy
> > of Common.java found in the HotSpot repository [0].
> 
> Yes.
> 
> > If these tests are HotSpot-specific, should they not be in the HotSpot
> > repository?
> 
> These tests test the container capabilities in Java code
> (Metrics.java). Container support has been added to hotspot and core
> libraries. These tests aren't hotspot specific. They are for the Java
> side.
>

Right, but the options you're changing and the Whitebox it relies on
are HotSpot specific. And both are duplicated in the HotSpot repository.

Would these tests run as is on e.g. OpenJ9? I doubt it.

> Thanks,
> Severin
> 
> > [0] https://hg.openjdk.java.net/jdk8u/jdk8u/hotspot/file/83661fdee9f0/test/testlibrary/com/oracle/java/testlibrary/Common.java#l67
> > 
> > Thanks,
> 

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222