[8u] RFR: 8250636: iso8601_time returns incorrect offset part on MacOS

[Sergey Nazarkin]

Hi Andrew,

thanks for the review. Updated version with copyright update is here
https://cr.openjdk.java.net/~snazarki/jdk8u-dev-webrev/8250636.1/

> - * Copyright (c) 1997, 2018, Oracle and/or its affiliates. All rights reserved.
> + * Copyright (c) 1997, 2020, Oracle and/or its affiliates. All rights reserved.


Sergey Nazarkin




> On Nov 30, 2020, at 20:16, Andrew Hughes <gnu.andrew at redhat.com> wrote:
> 
> On 18:34 Tue 15 Sep     , Sergey Nazarkin wrote:
>> Original Bug: https://bugs.openjdk.java.net/browse/JDK-8250636
>> Review: https://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2020-July/040894.html
>> 
>> Please review the backport of the fix for quite specific bug. The fix may be considered as ’too risky to fix’ since changes behavior existed for years.  
>> 
>> It appears Java for BSD-like systems (OSX particularly) prints time in iso8601format (used at GC logs) incorrectly.  Example of confused logs:
>> 
>> Europe/Moscow (DST isn't in use)
>> 2020-07-30T11:29:10.350+0300 # Linux 
>> 2020-07-30T11:29:10.350+0300 # Windows 
>> 2020-07-30T11:29:10.350-0300 # MacOS 
>> Europe/Berlin (DST is in use)
>> 2020-07-30T10:29:10.350+0200 # Linux 
>> 2020-07-30T10:29:10.350+0200 # Windows 
>> 2020-07-30T10:29:10.350-0100 # MacOS
>> 
>> The patch is not applied cleanly due to missed context and function signature change.
>> 
>> Webrev: http://cr.openjdk.java.net/~snazarki/jdk8u-dev-webrev/8250636/
>> 
>> Unfortunately the change breaks AIX build and additional patch need to be applied: 
>> https://bugs.openjdk.java.net/browse/JDK-8251365
>> 
>> Will create new review if this backport is considered as accepted. 
>> 
>> /Sergey
>> 
>> 
> 
> This seems to be missing the copyright header update that is in the 11u version.
> Otherwise looks ok.
> 
> Thanks,
> -- 
> Andrew :)
> 
> Senior Free Java Software Engineer
> OpenJDK Package Owner
> Red Hat, Inc. (http://www.redhat.com)
> 
> PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
> Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222