RFR (M): 8062808: Turn on the -Wreturn-type warning

[Andrew Hughes]

On 20:15 Thu 01 Oct     , Hohensee, Paul wrote:
> Reviving from https://mail.openjdk.java.net/pipermail/jdk8u-dev/2020-February/011088.html.
> 
> Xin’s last comment on https://bugs.openjdk.java.net/browse/JDK-8062808 notes that there are two remaining predecessor backports, https://bugs.openjdk.java.net/browse/JDK-8030350 and https://bugs.openjdk.java.net/browse/JDK-8036122, so this review request is for all three of them. They will be pushed together (but as separate changesets).
>

What is the motivation for backporting these two other fixes? I don't
see any obvious reason to include these and I didn't when I backported
JDK-8062808 myself.  Adding additional compiler warnings seems to be
asking for build breakage.

Though also not mentioned here, there is a motivation to backport
-Wreturn-type as it catches cases which can lead to crashes with some
compilers. I'm fine with that.

If we must do all three, it would have made sense to at least put them
in separate build promotions rather than rushing all three in together
like this. I see absolutely no reason for that.

> 
> Compiles with both fastdebug and slowdebug on linux. I’d greatly appreciate if someone could try osx and solaris.
>

On what architectures? Have you checked Zero?

> Thanks,
> Paul
> 
> 
> 
> 
> 

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222