[8u] RFR: 8160974: [TESTBUG] Mark more headful tests with @key headful.

Jonathan Dowland jdowland at redhat.com
Fri Oct 9 08:53:10 UTC 2020


Hi,

On Wed, Aug 05, 2020 at 11:19:52AM -0400, Zhengyu Gu wrote:
> On 7/20/20 9:48 AM, Jonathan Dowland wrote:
> > Hello,
> > 
> > Please review this backport of JDK-8160974 to 8u, for parity with
> > Oracle 8u271.
> > 
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8160974
> > jdk9 patch: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/fe58d505fffd
> > 
> > webrev:
> >      https://jmtd.net/tmp/JDK-8160974/
> 
> Jonathan is not a author right now, so I host his webrev.
> Webrev: http://cr.openjdk.java.net/~zgu/jonathan_downland/JDK-8160974/

Thank you, Zhengyu.

I've just confirmed Today that this still applies cleanly to the current
state of jdk8-dev/jdk.

Note that the webrev doesn't pass jcheck for two reasons: missing
reviewer, and invalid User. Hopefully that's not a blocker for
review (and a reviewer could fix the metadata during the review process?
Please add "Contributed-By: jdowland at redhat.com") because it's a bit of
a chicken-and-egg problem for folks who aren't yet Authors.

On 7/20/20 9:48 AM, Jonathan Dowland wrote:
> 228/596 hunks apply without modifications. 16 hunks required manual
> rework. The remainder were for files not present in jdk8u.  Those files
> were:
>      https://jmtd.net/tmp/JDK-8160974/files_not_present_in_jdk8u.txt

That URI is still live if it's any use for reviewing.


Thanks,

-- 
���� Jonathan Dowland <jdowland at redhat.com>
Senior Software Engineer, OpenJDK, Red Hat



More information about the jdk8u-dev mailing list