[8u] RFR: 8159690: [TESTBUG] Mark headful tests with @key headful.

[Jonathan Dowland]

Hi,


Reviewer still requested for this patch.

On Wed, Aug 05, 2020 at 11:21:10AM -0400, Zhengyu Gu wrote:
> On 7/20/20 5:35 AM, Jonathan Dowland wrote:
> > Please review this backport of JDK-8159690 to 8u, for parity with
> > Oracle 8u271.
> > 
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8159690
> > jdk9 patch: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/980da45565c8
> 
> Jonathan is not an author right now, so I host his webrev.
> Webrev: http://cr.openjdk.java.net/~zgu/jonathan_downland/JDK-8159690/

Thanks Zhengyu for hosting the Webrev for me.

I've just confirmed this still applies cleanly to the current state of
jdk8u-dev/jdk.

To pass jcheck, the metadata needs some adjustment

--- JDK-8159690.changeset       2020-10-07 16:44:41.000000000 +0100
+++ JDK-8159690.changeset       2020-10-09 10:11:28.018559201 +0100
@@ -1,14 +1,13 @@
 # HG changeset patch
-# User Jonathan Dowland <jdowland at redhat.com>
+# User zgu
 # Date 1595236773 -3600
 #      Mon Jul 20 10:19:33 2020 +0100
 # Node ID d1627672258b3e0fbee4cffb56f89cd79f307332
 # Parent  0955cfdaee9e105c46d25e3b25d1441ddf5c3a2c
 8159690: [TESTBUG] Mark headful tests with @key headful.
-
-Backport of 14851:980da45565c8 from jdk9.  542/842 hunks applied directly from
-the patch. 44 I resolved manually.  The remaining hunks are for filenames that
-do not exist in jdk8u.
+Summary: Backport of 14851:980da45565c8 from jdk9.
+Reviewed-by: your-ID-here
+Contributed-by: jdowland at redhat.com

On 7/20/20 5:35 AM, Jonathan Dowland wrote:
> 542/842 hunks applied directly from the original patch. 44 I resolved
> manually.  The remaining hunks are for filenames that do not exist in
> jdk8u. Those basenames are listed here:
>      https://jmtd.net/tmp/JDK-8159690/basenames_not_in_tree.txt
> 
> Note that there are two different tests with the basename
> "ImageTransferTest.java", only one of which is in jdk8u.


Thank you,

-- 
���� Jonathan Dowland <jdowland at redhat.com>
Senior Software Engineer, OpenJDK, Red Hat