[8u] RFR 8254673: call for JvmtiExport::post_vm_start() was removed by the fix for JDK-8249158

[Andrew Hughes]

On 13:53 Tue 13 Oct     , Andrew Brygin wrote:
> Hello,
> 
>  please review a fix for 8254673.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8254673
> Webrev: http://cr.openjdk.java.net/~bae/8u/8254673/webrev.00/
> 
>  The fix for JDK-8249158 [1] removes the call for
> JvmtiExport::post_vm_start() from Threads::create_vm():
> 
> https://hg.openjdk.java.net/jdk8u/jdk8u-dev/hotspot/rev/85e682d8ab91#l11.24
> 
>  This fix is supposed to be a backout of the fix for JDK-8233197 [2], so
> this removal seems to be done by a mistake, because the call for
> JvmtiExport::post_vm_start() was present there prior to the fix for
> JDK-8233197:
> https://hg.openjdk.java.net/jdk8u/jdk8u/hotspot/rev/26d1803768c7#l11.21
> 
>  This change causes failures in the vmTestbase suite [3], which is not
> yet included into jdk8u though. Probably some jvmti usecases could be
> affected also.
> 
> Thanks,
> Andrew.
> 
> [1] https://bugs.openjdk.java.net/browse/JDK-8249158
> [2] https://bugs.openjdk.java.net/browse/JDK-8233197
> [3]
> http://mail.openjdk.java.net/pipermail/jdk8u-dev/2020-January/010900.html
> 

Comparing the original fix and the backout, it's clear that this seems
to have been removed by mistake. I can only assume there were interim
changes which made the backout unclean.

I'll apply this as part of the CPU bundle.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222