Build failures on illumos (Solaris)

[Severin Gehwolf]

Hi Andrew,

On Mon, Oct 19, 2020 at 12:08 PM Andrew Brygin <abrygin at azul.com> wrote:
>
> We have seen this build issue, and use a separate mapfile for solaris.
> It is not much convenient, but seems to be most safe option to handle
> different sets of symbols for solaris and linux. Suggested patch is
> attached.

Yes, this seems fine. Could you please create a bug and post for
review when you get a chance?

Thanks,
Severin

> On 19/10/2020 12:51, Severin Gehwolf wrote:
> > On Mon, Oct 19, 2020 at 11:43 AM Peter Tribble <peter.tribble at gmail.com> wrote:
> >> On Mon, Oct 19, 2020 at 10:32 AM Severin Gehwolf <sgehwolf at redhat.com> wrote:
> >>>
> >>> Hi,
> >>>
> >>> On Fri, Oct 16, 2020 at 12:28 PM Peter Tribble <peter.tribble at gmail.com> wrote:
> >>>>
> >>>> Trying a build of 8u272-b09 on Solaris (specifically, illumos) I'm seeing a
> >>>> couple of
> >>>> build failures:
> >>>>
> >>>> Undefined                       first referenced
> >>>>  symbol                             in file
> >>>> Java_jdk_internal_platform_cgroupv1_Metrics_isUseContainerSupport
> >>>> /export/home/ptribble/ud/openjdk8u272/jdk/make/mapfiles/libjava/mapfile-vers
> >>>> ld: fatal: symbol referencing errors. No output written to
> >>>> /export/home/ptribble/ud/openjdk8u272/build/solaris-x86_64-normal-server-release/jdk/lib/amd64/libjava.so
> >>>>
> >>>> That symbol clearly doesn't apply to Solaris.
> >>>>
> >>>> Undefined                       first referenced
> >>>>  symbol                             in file
> >>>> Java_sun_awt_X11_XToolkit_getDefaultScreenData
> >>>> /export/home/ptribble/ud/openjdk8u272/jdk/make/mapfiles/libawt_xawt/mapfile-vers
> >>>> ld: fatal: symbol referencing errors. No output written to
> >>>> /export/home/ptribble/ud/openjdk8u272/build/solaris-x86_64-normal-server-release/jdk/lib/amd64/libawt_xawt.so
> >>>>
> >>>> That appears to have been removed from
> >>>> jdk/src/solaris/native/sun/xawt/XToolkit.c
> >>>> but still lingers in the mapfile.
> >>>>
> >>>> Removing those two errant entries from the map files allows the build to
> >>>> complete, and my initial testing looks good.
> >>>
> >>> Thanks for the report. We are aware of this. Unfortunately, we don't
> >>> have a system to reproduce this and it's somewhat low priority for us.
> >>> If you'd be willing to contribute patches, I'd gladly accept and
> >>> approve it for 8u.
> >>
> >>
> >> Sure. Here's a patch to fix both.
> >
> > I'm afraid this would break Linux builds (and maybe others). One
> > possible fix could be to only remove those lines from the map files if
> > the build platform is solaris.
> >
> > Thanks,
> > Severin
> >