[RFR] jdk8u272-b10/jdk8u272-ga

Aleksey Shipilev shade at redhat.com
Wed Oct 21 06:32:14 UTC 2020


On 10/21/20 7:40 AM, Andrew Hughes wrote:
> Here are the jdk8u272-b10 changes (the security patches) for the jdk8u
> repository:
> 
> Webrevs: https://cr.openjdk.java.net/~andrew/openjdk8/8u272/

Minor things:

*) src/share/native/sun/awt/image/jpeg/jdhuff.c
    src/share/native/sun/awt/image/jpeg/jdinput.c
    src/share/native/sun/awt/image/jpeg/jdmarker.c
    src/share/native/sun/awt/image/jpeg/jpeglib.h

  ...seem weirdly empty. They are intended to be that way, right?

*) In src/share/classes/java/io/ObjectInputStream.java, blocks like these:

@@ -1894,6 +1923,11 @@
              }
          } catch (ClassNotFoundException ex) {
              resolveEx = ex;
+        } catch (OutOfMemoryError memerr) {
+            IOException ex = new InvalidObjectException("Proxy interface limit exceeded: " +
+                    Arrays.toString(ifaces));
+            ex.initCause(memerr);
+            throw ex;
          }

  ...look way too optimistic to me. If that's a real OOME, then allocations in this block would 
highly likely to fail themselves. If that's a fake OOMEs, then they are thrown where?

I assume it is a fake OOME: I see the changeset (8249927: Specify limits of 
jdk.serialProxyInterfaceLimit), which seems to imply this. But, there is no 
"jdk.serialProxyInterfaceLimit" in sight in the patch or in existing source.

> Ok to push?

Yes, but the nits above need to be worked out, I think.

-- 
Thanks,
-Aleksey



More information about the jdk8u-dev mailing list