[8u] RFR: 8255003: Build failures on Solaris (was Re: Build failures on illumos (Solaris))

[Andrew Hughes]

On 09:17 Wed 21 Oct     , Severin Gehwolf wrote:
> Hi,
> 
> On Tue, 2020-10-20 at 21:14 +0300, Andrew Brygin wrote:
> > I have updated the fix according to following comment:
> > 
> > https://bugs.openjdk.java.net/browse/JDK-8255003?focusedCommentId=14375484&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14375484
> > 
> > The removal of Java_sun_awt_X11_XToolkit_getDefaultScreenData will be
> > tracked as JDK-8251840.
> 
> Thank you!
> 
> > Please take a look to updated webrev:
> > 
> > http://cr.openjdk.java.net/~bae/8u/8255003/webrev.01/
> 
> Does this actually build on Windows? I'm thinking not, since it's
> missing a mapfile for windows, no?
> 
> How about special case Linux instead and let other platforms use the
> old, pre JDK-8250627, mapfile-vers and use the one adding
> Java_jdk_internal_platform_cgroupv1_Metrics_isUseContainerSupport on
> Linux like so, perhaps?
> 
> https://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8255003/01/webrev/
> 
> Thanks,
> Severin
> 

I hadn't even considered Windows, as it used to be a pretty separate
build in the old build system. I think this looks a better idea, but
would be good to see a diff --git patch, so the changes in the new
file are clear.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222