OpenJDK 8u272 Released
Aleksey Shipilev
shade at redhat.com
Thu Oct 22 07:35:17 UTC 2020
On 10/21/20 6:00 PM, Andrew Hughes wrote:
>> From my point of view, the ideal workflow would be to push the changes
>> to the OpenJDK update repos right after the embargo was lifted. After
>> that anybody can use these repos as "golden master" and create source
>> bundles, binararies, etc from them. Or am I missing something?
>
> That might be better, but it would be a change for how we have done
> things for the last decade. As I say, the repos, source bundles and
> binary bundles all have different target audiences. I don't think it's
> correct to assume everyone who wants the new release is able to build
> their own from a repository.
I am reluctantly against pushing anything to the public repos without a second (hopefully
non-involved) person looking at it. The rare exceptions are clean merges from other public repos.
Human errors happen, and reviews help to catch them early before they propagate. IMO, 8u and 11u
work is too important to take process shortcuts.
Even if formally CPU RFR can only result in prompt fixes on top of already released builds, still,
this would be the second line of defense against proliferating obvious CPU regressions (the first
line being VG itself). That is, if anyone would detect a source code problem with a public CPU
patch, that is better to be discovered the moment embargo lifts. This is coincidentally when CPU RFR
happens.
Therefore, I would still like to see RFRs sent out for CPU stuff.
> Note that you may not have noticed this with previous releases because
> Aleksey has been doing an excellent job of reviewing them almost
> immediately. I'm sure he'd appreciate the extra sleep if he's no
> longer on the hook to do that late on unembargo days.
Thanks, yes, that would make my life easier :)
But this actually gives us a middle ground here: if we want the patches to be pushed promptly and
with review, then consider being on-call around the embargo datetime, so you can review/clear
Andrew's RFR promptly (hopefully before Andrew himself calls it a day). As Andrew mentions, I did
that for previous releases, so maybe other folks would consider to stay around for next releases
too. That's how it is supposed to work, methinks: if you want something to happen (quickly) with a
due process, then show up and give a helping hand.
--
Thanks,
-Aleksey
More information about the jdk8u-dev
mailing list