[8u] RFR 8069211: (zipfs) ZipFileSystem creates corrupted zip if entry output stream gets closed more than once

Hohensee, Paul hohensee at amazon.com
Wed Oct 28 15:50:31 UTC 2020


Lgtm, except that I'd add a bug id section in case there are future backports that affect ZipFSTester.java, vis

 * @bug 8069211

Thanks,
Paul

On 10/9/20, 6:42 AM, "jdk8u-dev on behalf of Zhengyu Gu" <jdk8u-dev-retn at openjdk.java.net on behalf of zgu at redhat.com> wrote:

    Hi,

    I would like to backport this patch to 8u for parity with Oracle 8u281.

    The original patch does not apply cleanly.

    1) ZipFileSystem.java
    Patch contains bad copyright year.

    + * Copyright (c) 2009, 201, Oracle and/or its affiliates. All rights
    reserved.

    2) ZipFSTester.java
    - 8u uses wildcard imports
    - 8u does not have bug id section
    - Placement of test8069211() method call

    The original bug: https://bugs.openjdk.java.net/browse/JDK-8069211
    The original patch:
    http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/b6ae6184b241


    8u webrev: http://cr.openjdk.java.net/~zgu/JDK-8069211-8u/webrev.00/

    Thanks,

    -Zhengyu




More information about the jdk8u-dev mailing list