Re: 回复: 回复: [8u] RFR(XS) JFR generate same symbol ID for different symbols (high probabily with CDS)(Internet mail)

[Andrew Dinn]

Hi Hui,

On 19/10/2020 15:07, kalinshi(施慧) wrote:
> Please help review this JFR issue again in 8u. This problem can be easily reproduced with CDS and reproduce steps in JBS.
> 
> Fix includes:
> 1.  Remove map_symbol/map_cstring methods with only hashcode, all lookup must pass symbol or cstring with hashcode.
> 2.  In JfrSymbolId::equals methods, compare symbol reference or cstring contents when hashcodes are same.
> 3.  Rebuild anonymous klass cstring when search its sctring entry id.
> 
> JBS: https://bugs.openjdk.java.net/browse/JDK-8253837
> Webrev: http://cr.openjdk.java.net/~hshi/8253837/webrev_2/
This new patch looks ok to me. However, before accepting it I'd like to
hear details of whatever testing you have performed.

regards,


Andrew Dinn
-----------