[8u] RFR: 8159690: [TESTBUG] Mark headful tests with @key headful.

[Hohensee, Paul]

Hi, Jonathan, just a couple of comments.

Looks like you're missing a file in your patch, namely

test/java/awt/image/DrawImage/IncorrectUnmanagedImageSourceOffset.java

For that file, the original changeset has:

diff --git a/test/java/awt/image/DrawImage/IncorrectUnmanagedImageSourceOffset.java b/test/java/awt/image/DrawImage/IncorrectUnmanagedImageSourceOffset.java
--- a/test/java/awt/image/DrawImage/IncorrectUnmanagedImageSourceOffset.java
+++ b/test/java/awt/image/DrawImage/IncorrectUnmanagedImageSourceOffset.java
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2014, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2014, 2016, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * This code is free software; you can redistribute it and/or modify it
@@ -43,6 +43,7 @@
 
 /**
  * @test
+ * @key headful
  * @bug 8029253
  * @summary Tests asymmetric source offsets when unmanaged image is drawn to VI.
  *          Results of the blit to compatibleImage are used for comparison.

Also, the following changeset header should work. It conforms to the guideline that the original User be preserved.

# HG changeset patch
# User goetz
# Date 1465893899 -7200
#      Tue Jun 14 10:44:59 2016 +0200
# Node ID 980da45565c8583637a0842ba9d4eec217bdf366
# Parent  218c24b207fd92383fe7d880d7f7f06820cd5246
8159690: [TESTBUG] Mark headful tests with @key headful.
Reviewed-by: simonis, alexsch
Contributed-by: jdowland at redhat.com

Thanks,
Paul

On 10/29/20, 8:06 AM, "jdk8u-dev on behalf of Zhengyu Gu" <jdk8u-dev-retn at openjdk.java.net on behalf of zgu at redhat.com> wrote:

    Lgtm.

    -Zhengyu

    On 8/5/20 11:21 AM, Zhengyu Gu wrote:
    > Hi,
    >
    > On 7/20/20 5:35 AM, Jonathan Dowland wrote:
    >> Hello,
    >>
    >> Please review this backport of JDK-8159690 to 8u, for parity with
    >> Oracle 8u271.
    >>
    >> Bug: https://bugs.openjdk.java.net/browse/JDK-8159690
    >> jdk9 patch: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/980da45565c8
    >>
    >> webrev:
    >>      https://jmtd.net/tmp/JDK-8159690/
    >
    > Jonathan is not an author right now, so I host his webrev.
    > Webrev: http://cr.openjdk.java.net/~zgu/jonathan_downland/JDK-8159690/
    >
    > Thanks,
    >
    > -Zhengyu
    >
    >>
    >> 542/842 hunks applied directly from the original patch. 44 I resolved
    >> manually.  The remaining hunks are for filenames that do not exist in
    >> jdk8u. Those basenames are listed here:
    >>      https://jmtd.net/tmp/JDK-8159690/basenames_not_in_tree.txt
    >>
    >> Note that there are two different tests with the basename
    >> "ImageTransferTest.java", only one of which is in jdk8u.
    >>
    >>
    >> Thank you,
    >>