[8u] RFR: 8252470: java/awt/dnd/DisposeFrameOnDragCrash/DisposeFrameOnDragTest.java fails on Windows

[Alex Kashchenko]

On 10/30/20, Andrew Hughes <gnu.andrew at redhat.com> wrote:
> On 12:46 Wed 23 Sep     , Alex Kashchenko wrote:
>> Hi,
>>
>> Please review the backport of JDK-8252470 to 8u-dev:
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8252470
>>
>> Original changeset: https://hg.openjdk.java.net/jdk/jdk/rev/5870df313be1
>>
>> 8u webrev: https://cr.openjdk.java.net/~akasko/jdk8u/8252470/webrev.00/
>>
>>
>> Backport depends on:
>>
>> 8132664: closed/javax/swing/DataTransfer/DefaultNoDrop/DefaultNoDrop.java
>> locks on Windows (not public, see:
>> https://mail.openjdk.java.net/pipermail/jdk8u-dev/2020-September/012731.html
>> )
>> 8232114: JVM crashed at imjpapi.dll in native code
>>
>>
>> After fixing paths, changes to awt_Toolkit.cpp apply cleanly.
>> Comment-only
>> change to DisposeFrameOnDragTest.java does not apply cleanly, because it
>> depends on:
>>
>> 8198333: ProblemList should be updated for headless mode
>>
>> that seems to be problematic to backport. It is proposed to exclude
>> changes
>> to DisposeFrameOnDragTest.java from the backport.
>>
>> Testing: checked that it compiles with vs2010 and vs2017, ran
>> jck:api/java_awt .
>>
>>
>> PS: it is not clear whether this fix need to be brought to 15/13/11 first
>> before proceeding with 8, please let me know if that is the case.
>>
>> --
>> -Alex
>>
>
> 8198333 actually only makes a small change to the header format:
>
> ---
> a/test/jdk/java/awt/dnd/DisposeFrameOnDragCrash/DisposeFrameOnDragTest.java
> +++
> b/test/jdk/java/awt/dnd/DisposeFrameOnDragCrash/DisposeFrameOnDragTest.java
> @@ -22,7 +22,8 @@
>   */
>
>  /**
>  - * @test @summary JVM crash if the frame is disposed in
> DropTargetListener
>  + * @test
>  + * @summary JVM crash if the frame is disposed in DropTargetListener
>    * @key headful
>    * @author Petr Pchelko
>    * @library ../../regtesthelpers
>
>
> The test itself is present in 8u, so I see no reason why this patch
> can't include the bug ID line and copyright change from the 11u version.
> You could also include the above cleanup.

Thanks for the review! Besides JDK-8198333, changes to
DisposeFrameOnDragTest.java also depend on JDK-8179889 (comma) and
JDK-8160974 (headful tag).

Updated webrev including changes from the issues above:

https://cr.openjdk.java.net/~akasko/jdk8u/8252470/webrev.01/


--
-Alex