[8u] RFR: 8159690: [TESTBUG] Mark headful tests with @key headful.

[Hohensee, Paul]

I've started the process by tagging 8039279 and 8041592, both of which apply cleanly. The next two, 8038631 and 8041915, have already been backported.

On 10/30/20, 8:18 AM, "jdk8u-dev on behalf of Hohensee, Paul" <jdk8u-dev-retn at openjdk.java.net on behalf of hohensee at amazon.com> wrote:

    Looking at [0], there are quite a few backports that might be involved, and figuring out which to use (and the ones they in turn depend on) will be difficult. Shall we contemplate duplicating your 2016 effort completely instead? That at least would be straightforward: just apply backports in the order given.

    Thanks,
    Paul

    On 10/29/20, 11:58 PM, "jdk8u-dev on behalf of Andrew Hughes" <jdk8u-dev-retn at openjdk.java.net on behalf of gnu.andrew at redhat.com> wrote:

        On 10:35 Mon 20 Jul     , Jonathan Dowland wrote:
        > Hello,
        >
        > Please review this backport of JDK-8159690 to 8u, for parity with
        > Oracle 8u271.
        >
        > Bug: https://bugs.openjdk.java.net/browse/JDK-8159690
        > jdk9 patch: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/980da45565c8
        >
        > webrev:
        >     https://jmtd.net/tmp/JDK-8159690/
        >
        > 542/842 hunks applied directly from the original patch. 44 I resolved
        > manually.  The remaining hunks are for filenames that do not exist in
        > jdk8u. Those basenames are listed here:
        >     https://jmtd.net/tmp/JDK-8159690/basenames_not_in_tree.txt
        >
        > Note that there are two different tests with the basename
        > "ImageTransferTest.java", only one of which is in jdk8u.
        >
        >
        > Thank you,
        >
        > --
        > ���� Jonathan Dowland <jdowland at redhat.com>
        > Senior Software Engineer, OpenJDK, Red Hat
        >

        I'm quite concerned about the number of tests that are being omitted
        here.  The referenced file lists 136 omitted tests, which amounts to
        about 30% of the original patch of 443 files. I don't think backporting
        just 70% of a patch is appropriate.

        It turns out I did backport this patch myself some time ago [0].
        As you can see from the bug, the focus there was on bringing in
        these bundles of tests that were opened up during the 9u lifecycle.
        Tagging them with @headful was just a final touch. I think it's
        worth looking at some of these first, as some of these changes
        bring in 40-odd of your missing tests.

        I'll try and have a look tomorrow.

        [0] https://icedtea.classpath.org/bugzilla/show_bug.cgi?id=3077

        Thanks,
        --
        Andrew :)

        Senior Free Java Software Engineer
        OpenJDK Package Owner
        Red Hat, Inc. (http://www.redhat.com)

        PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
        Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222