[8u] RFR: 8244225: stringop-overflow warning on strncpy call from compile_the_world_in
Severin Gehwolf
sgehwolf at redhat.com
Tue Sep 1 12:23:32 UTC 2020
Hi,
Could I please get a review of this 8u backport? The JDK 11u patch
doesn't apply cleanly since string_ends_with() function isn't in 8u.
Therefore, the context is different enough for the patch to not apply
cleanly. This is in a NOT_PRODUCT() path of the VM and should be low
risk. I'm proposing this for review for JDK 8u parity.
Bug: https://bugs.openjdk.java.net/browse/JDK-8244225
webrev: https://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8244225/01/webrev/
Testing: Manual on a fastdebug build of the JVM. Compiling classLoader.o
with -Wstringop-overflow. Warning present before the fix and it's
gone after.
Thoughts? I'm not sure if this is worth the churn of doing the
backport, though.
Thanks,
Severin
More information about the jdk8u-dev
mailing list