[8u] RFR 8u: Windows build failed after 8222079 backport

Andrew Hughes gnu.andrew at redhat.com
Mon Sep 7 06:37:35 UTC 2020


On 17:32 Thu 03 Sep     , Alex Kashchenko wrote:
> Hi Zhengyu,
> 
> On 8/31/20, Zhengyu Gu <zgu at redhat.com> wrote:
> > Please review this small fix for Windows build after JDK-8222079 backport.
> >
> >
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8252573
> > Webrev: http://cr.openjdk.java.net/~zgu/JDK-8252573/webrev.00/
> >
> > Test:
> >    64-bit and 32-bit builds on Windows
> 
> The change looks good to me (not a reviewer), I've checked that it
> fixes the problem with vs2010 compilation.
> 
> --
> -Alex
> 

It would help if the error message was given and an explanation of
why the patch fixes it.

If Alex is happy this fixes the compilation error, that should be ok.
Has it being checked on GNU/Linux to make sure it doesn't break things there?

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222


More information about the jdk8u-dev mailing list