[8u] RFR 8151678: com/sun/jndi/ldap/LdapTimeoutTest.java failed due to timeout on DeadServerNoTimeoutTest is incorrect

[Zhengyu Gu]

Hi Andrew,

On 9/7/20 2:10 AM, Andrew Hughes wrote:
> On 09:24 Sat 29 Aug     , Zhengyu Gu wrote:
>> I would like to backport this patch for parity with Oracle 8u271.
>>
> 
> There seem to be a couple of additional copyright header changes in
> this backport, in
> src/share/classes/com/sun/jndi/ldap/DefaultLdapDnsProvider.java and
> src/share/classes/com/sun/jndi/ldap/LdapDnsProviderService.java. Where
> do these come from?

They came from the original JDK-8151678 patch [1]


> 
> With the changes to LdapTimeoutTest.java, .copy() is not the same
> as .toCompletableFuture(), as the former creates a new CompleteableFuture
> (via newInCompleteFuture(), another 9u addition) that relays the
> result of the original, while the latter would appear to be just the
> same as returning starting directly. A closer equivalent would appear
> to be starting.thenApply((x) -> x), as suggested in the documentation of
> copy().
Updated: http://cr.openjdk.java.net/~zgu/JDK-8151678-8u/webrev.01/

> 
> Do the amended tests complete successfully?
> 
Yes, before and after your suggested change.

Test:
   Reran jdk_other.

Thanks,

-Zhengyu


[1] https://hg.openjdk.java.net/jdk/jdk/rev/1def54255e93
>