[8u] RFR: 8252395: [8u] --with-native-debug-symbols=external doesn't include debuginfo files for binaries

[Andrew Hughes]

On 13:44 Mon 31 Aug     , Severin Gehwolf wrote:
> Sorry, wrong webrev. Now corrected.
> 
> On Mon, 2020-08-31 at 10:02 +0200, Severin Gehwolf wrote:
> > Hi,
> > 
> > Could I get a reivew of this 8u specific bug please? When configured
> > --with-native-debug-symbols=external,zipped the resulting external
> > debuginfo files for binaries (in images/bin folder) aren't there.
> > 
> > In OpenJDK 8u there is some special casing involved for bin/java and
> > bin/unpack200. Thus, I had to special case them for the debuginfo
> > variant files too otherwise those files would be missing in the images
> > folders (j2sdk-image, j2re-image).
> > 
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8252395
> 
> webrev: https://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8252395/02/webrev/
> 
> > 
> > Testing: Build in configs --with-native-debugsymbols={zipped,external,internal,none}
> >          on Linux x86 and manually debugging some launcher code. Works now
> >          with symbols. Symbols were missing before this patch.
> > 
> 
> Thanks,
> Severin
> 

Patch looks ok, particularly when there is a comment in the original,
"For unknown reason the debuginfo files for executables are not put
into images" :)

This was all removed on mass in JDK-8049367 for the module system, so
there is no obvious backport.

Is any follow-on change for Windows necessary?

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222