[RFR]: JDK-8196196: Headful tests should not be run in headless mode
Mario Torre
neugens at redhat.com
Tue Sep 8 16:24:05 UTC 2020
Hi Severin,
I got a new version here:
https://cr.openjdk.java.net/~neugens/8196196/webrev.01/
It's essentially the same, except a couple of minor things.
Cheers,
Mario
On Fri, Aug 21, 2020 at 3:05 PM Mario Torre <neugens at redhat.com> wrote:
>
> Hi Severin,
>
> Thanks for the review!
>
> Unfortunately I forgot to add the fix-request label, and I just
> realised that there are some changes like BadDisplayTest.java now is
> gone.
>
> This is a trivial change, but I need to go back at it and see if some
> of the modifications I did to adapt the patch to 8u are still
> necessary, I think I'll need to resubmit the patch for review...
>
> Cheers,
> Mario
>
> On Fri, Aug 21, 2020 at 2:25 PM Severin Gehwolf <sgehwolf at redhat.com> wrote:
> >
> > On Wed, 2020-07-08 at 14:39 +0200, Mario Torre wrote:
> > > Hi all,
> > >
> > > I would like to have a review for the following bug since it doesn't
> > > apply cleanly:
> > >
> > > https://bugs.openjdk.java.net/browse/JDK-8196196
> > >
> > > I had to rework a number of them, for example a couple of tests don't
> > > exist in JDK8u while other had test code changes that didn't apply to
> > > 8u. The new webrev is here:
> > >
> > > http://cr.openjdk.java.net/~neugens/8196196/webrev.00/
> >
> > This looks OK to me.
> >
> > Thanks,
> > Severin
> >
>
>
> --
> Mario Torre
> Associate Manager, Software Engineering
> Red Hat GmbH <https://www.redhat.com>
> 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898
--
Mario Torre
Associate Manager, Software Engineering
Red Hat GmbH <https://www.redhat.com>
9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898
More information about the jdk8u-dev
mailing list