[8u] RFC: 8172695: (scanner) java/util/Scanner/ScanTest.java fails

[Severin Gehwolf]

Hi,

Sorry, for being late on this.

On Mon, 2020-05-25 at 20:48 +0100, Alex Kashchenko wrote:
> Hi,
> 
> I'd like to solicit comments and suggestions about the backport of 
> JDK-8172695 to 8u.
> 
> Jira issue: https://bugs.openjdk.java.net/browse/JDK-8172695

diff stat for this is:

$ hg diff -c c9865fee1a6d --stat
 test/jdk/java/util/Scanner/ScanTest.java |  30 ++++++++---------------
-------
 1 files changed, 8 insertions(+), 22 deletions(-)

> There were a number of changes to ScanTest and to Scanner itself in 9+, 
> so to backport 8172695 cleanly the following issues need to be 
> backported as well:
> 
> 8132206: move ScanTest.java into OpenJDK
> 8132745: TEST_BUG: minor cleanup of java/util/Scanner/ScanTest.java

These two bugs are already in jdk8u-dev now.

> 8072722: add stream support to Scanner [excluding public API changes]
> 8139414: java.util.Scanner hasNext() returns true, next() throws 
> NoSuchElementException
> 8159545: closed/java/io/Console/TestConsole.java failed with exit code 1 
> [not public, see: https://hg.openjdk.java.net/jdk/jdk/rev/e5d52546ba3a ]
> 8166261: Scanner.nextInt(int) (and similar methods) throws 
> PatternSyntaxException
> 8186157: (scanner) Modify java/util/Scanner/ScanTest.java to fail if 
> English Locale unavailable
> 
> What would be the preferred way to bring this to 8u? Is it better to 
> backport these changes one by one, or just take 8172695 and modify it 
> for 8u? Should bugfixes to Scanner itself (8139414 and 8166261) be 
> backported in latter case?

That's a way too long a bug tail for a simple test-only fix for a
stable JDK release!

So please could we not make the required test changes of 8172695 now
without bringing in any more of these bugs?

8072722 is a major concern. Why bring in an enhancement to Scanner for
a test-only backport?

Thanks,
Severin