RFR backport: 8207766: [testbug] Adapt tests for Aix.

[Doerr, Martin]

Hi Andrews ��

Good catch! I hadn’t noticed this test exists in 8u, either.
New webrev looks good.

When adding the jdk8u-fix-request, please also prefix your last comment with “Fix Request”.
(See http://openjdk.java.net/projects/jdk-updates/approval.html)

Thanks and best regards,
Martin


From: Andrew Leonard <andrew_m_leonard at uk.ibm.com>
Sent: Donnerstag, 17. September 2020 11:00
To: Andrew Hughes <gnu.andrew at redhat.com>
Cc: jdk8u-dev at openjdk.java.net; Doerr, Martin <martin.doerr at sap.com>
Subject: RE: RFR backport: 8207766: [testbug] Adapt tests for Aix.

Hi Andrew,
I've updated the webrev with the TestNssDbSqlite.java change and re-tested, new webrev here:
http://cr.openjdk.java.net/~aleonard/8207766/webrev.01
thanks
Andrew

Andrew Leonard
Java Runtimes Development
IBM Hursley
IBM United Kingdom Ltd
internet email: andrew_m_leonard at uk.ibm.com<mailto:andrew_m_leonard at uk.ibm.com>




From:        Andrew Hughes <gnu.andrew at redhat.com<mailto:gnu.andrew at redhat.com>>
To:        Andrew Leonard <andrew_m_leonard at uk.ibm.com<mailto:andrew_m_leonard at uk.ibm.com>>
Cc:        "Doerr, Martin" <martin.doerr at sap.com<mailto:martin.doerr at sap.com>>, "jdk8u-dev at openjdk.java.net<mailto:jdk8u-dev at openjdk.java.net>" <jdk8u-dev at openjdk.java.net<mailto:jdk8u-dev at openjdk.java.net>>
Date:        16/09/2020 16:32
Subject:        [EXTERNAL] Re: RFR backport: 8207766: [testbug] Adapt tests for Aix.
________________________________



On 15:11 Wed 16 Sep     , Andrew Leonard wrote:
> Thanks Martin,
> I'm also after a "sponsor" as I am not a committer, so if yourself or
> anyone else is able to sponsor please?
> Thanks
> Andrew
>
> Andrew Leonard
> Java Runtimes Development
> IBM Hursley
> IBM United Kingdom Ltd
> internet email: andrew_m_leonard at uk.ibm.com<mailto:andrew_m_leonard at uk.ibm.com>
>

The bug needs to be flagged with jdk8u-fix-request and approved
before commit. I can do the commit on your behalf once approved.

With regard to the patch itself, it seems to be missing the change
to jdk/test/sun/security/pkcs11/Secmod/TestNssDbSqlite.java. Was
this intentional?

The omission of jdk/test/tools/launcher/SourceMode.java makes sense
as 8u does not have 8201274: Launch Single-File Source-Code Programs.
The changes to use the 8u ProblemList format also look right.

Thanks,
--
Andrew :)

Senior Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com<http://www.redhat.com/>)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
[attachment "signature.asc" deleted by Andrew Leonard/UK/IBM]


Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number 741598.
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU