PING? RE: RFR: 8258669: fastdebug jvm crashes when do event based tracing for monitor inflation

[Yangfei (Felix)]

Hi,

Thanks for reviewing this fix.  I have tagged this for approval.

Felix

> -----Original Message-----
> From: Hohensee, Paul [mailto:hohensee at amazon.com]
> Sent: Thursday, April 1, 2021 4:44 AM
> To: Yangfei (Felix) <felix.yang at huawei.com>; jdk8u-dev at openjdk.java.net
> Subject: Re: PING? RE: RFR: 8258669: fastdebug jvm crashes when do event
> based tracing for monitor inflation
> 
> Lgtm.
> 
> Thanks,
> Paul
> 
> -----Original Message-----
> From: jdk8u-dev <jdk8u-dev-retn at openjdk.java.net> on behalf of "Yangfei
> (Felix)" <felix.yang at huawei.com>
> Date: Wednesday, February 17, 2021 at 7:26 PM
> To: "jdk8u-dev at openjdk.java.net" <jdk8u-dev at openjdk.java.net>
> Subject: RE: PING? RE: RFR: 8258669: fastdebug jvm crashes when do event
> based tracing for monitor inflation
> 
> Hi,
> 
>   Anyone want to take a look at this?
>   As this adds back "cause" information for the monitor inflation event, it
> should also improves basic functionality of 8u JFR event-based tracing.
> 
> Thanks,
> Felix
> 
> > -----Original Message-----
> > From: Yangfei (Felix)
> > Sent: Tuesday, January 12, 2021 3:39 PM
> > To: 'jdk8u-dev at openjdk.java.net' <jdk8u-dev at openjdk.java.net>
> > Subject: PING? RE: RFR: 8258669: fastdebug jvm crashes when do event
> > based tracing for monitor inflation
> >
> > Any comments?
> >
> > > -----Original Message-----
> > > From: Yangfei (Felix)
> > > Sent: Friday, December 18, 2020 8:35 PM
> > > To: jdk8u-dev at openjdk.java.net
> > > Subject: RFR: 8258669: fastdebug jvm crashes when do event based
> > > tracing for monitor inflation
> > >
> > > Hi,
> > >
> > >     Bug: https://bugs.openjdk.java.net/browse/JDK-8258669
> > >     Webrev: http://cr.openjdk.java.net/~fyang/8258669/webrev.00
> > >
> > >     By referencing jdk11u, I think the reason is that we are not
> > > setting the "cause" in post_monitor_inflate_event for jdk8u.
> > >     Proposed patch adds back the missing code changes in: 8138562:
> > > Event based tracing should cover monitor inflation. Also enabled
> > > code in MonitorInflateCauseConstant::serialize.
> > >     Since this only adds some extra "cause" information for the
> > > monitor inflation event, I think it should be low risk.
> > >     Performed full jtreg test based on the latest jdk8u-dev.  OK?
> > >
> > > Thanks,
> > > Felix