RFR: 8u backport of JDK-8211301 [macos] support full window content options

[Alvarez, David]

Hi,

I've created JDK-8265238 [1] to keep track of this

David

--
[1] https://bugs.openjdk.java.net/browse/JDK-8265238


On 4/14/21 11:51 AM, Alvarez, David wrote:
> Hi,
> 
> I want to mention we have faced a compilation error caused by this patch
> when building OpenJDK8 using Xcode 6.3.1 on OSX 10.10.
> 
> The error seems to be cause by NSWindow contentView property being
> defined on that version of the ApplicationKit as an object of type id,
> instead of an NSView (even if the documentation stated contentView will
> always be an id). Newer versions of the AppKit will define the
> contentView of an NSWindow as an NSView object, so the issue will not
> appear.
> 
> Apple's documentation for Cocoa Application Kit is no longer online, but
> I have found a mirror [1] that shows how NSWindow contentFrame was
> defined as such:
> 
> contentView
> - (id)contentView
> Returns the receivers’s content view, the highest accessible NSView
> object in the receiver’s view hierarchy.
> 
> This is compared with the current documentation [2]:
> @property(strong) __kindof NSView *contentView;
> 
> We have fixed our builds by adding a cast to NSView, but I wanted to
> leave this here in case someone else faces the same issue.
> 
> David
> 
> --
> [1]
> http://mirror.informatimago.com/next/developer.apple.com/documentation/Cocoa/Reference/ApplicationKit/ObjC_classic/Classes/NSWindow.html#//apple_ref/doc/uid/20000013/contentView
> 
> [2]
> https://developer.apple.com/documentation/appkit/nswindow/1419160-contentview?language=objc
> 
> On 2/11/21 10:08 AM, Severin Gehwolf wrote:
>> CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.
>>
>>
>>
>> Hi,
>>
>> On Thu, 2021-02-11 at 16:55 +0100, Andreas Ahlenstorf wrote:
>>> Hi Severin,
>>>
>>> On Thu, Feb 11, 2021, at 10:39, Severin Gehwolf wrote:
>>>
>>>> The JDK 11 patch set the updated year to 2018, not 2021. Please keep
>>>> 2018. The reason for this is to keep code bases in sync as much as
>>>> possible.
>>>
>>> Thanks. Will fix.
>>>
>>>> What kind of testing have you done?
>>>
>>> jtreg on jdk/test/java/awt/Window.
>>
>> OK thanks, I can sponsor this for you.
>>
>> Cheers,
>> Severin
>>