[8u] RFR 8072767: DefaultCellEditor for comboBox creates ActionEvent with wrong source object

Hohensee, Paul hohensee at amazon.com
Tue Apr 27 18:12:28 UTC 2021


Lgtm.

Thanks,
Paul

-----Original Message-----
From: jdk8u-dev <jdk8u-dev-retn at openjdk.java.net> on behalf of Zhengyu Gu <zgu at redhat.com>
Date: Monday, January 18, 2021 at 7:22 AM
To: jdk8u-dev <jdk8u-dev at openjdk.java.net>
Subject: [8u] RFR 8072767: DefaultCellEditor for comboBox creates ActionEvent with wrong source object

Hi,

I would like to backport this patch to openjdk8u, for parity with Oracle
8u291.

The original patch applies cleanly. However, the test failed on Fedora
due to component layout issue. Please see comments in bug for details.

I added a delay to ensure that layout is stable before test starts to
execute.

diff -r 15ca08c8faf5 test/javax/swing/JComboBox/8072767/bug8072767.java
--- a/test/javax/swing/JComboBox/8072767/bug8072767.java        Wed Apr
15 14:38:13 2015 +0400
+++ b/test/javax/swing/JComboBox/8072767/bug8072767.java        Mon Jan
18 10:11:16 2021 -0500
@@ -59,12 +59,12 @@
          robot.setAutoDelay(50);
          SwingUtilities.invokeAndWait(bug8072767::createAndShowGUI);
          robot.waitForIdle();
+        robot.delay(500);
          SwingUtilities.invokeAndWait(() -> {
              point = table.getLocationOnScreen();
              Rectangle rect = table.getCellRect(0, 0, true);
              point.translate(rect.width / 2, rect.height / 2);
          });



Original bug: https://bugs.openjdk.java.net/browse/JDK-8072767
Original patch: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/2ca1d772b1f1

8u webrev: http://cr.openjdk.java.net/~zgu/JDK-8072767-8u/webrev.00/

Test:
  Test passed on Fedora/Ubuntu Linux x86_64

Thanks,

-Zhengyu




More information about the jdk8u-dev mailing list