[8u] RFR: 8256818: SSLSocket that is never bound or connected leaks socket resources

[Alex Kashchenko]

On 4/27/21, Hohensee, Paul <hohensee at amazon.com> wrote:
> Reviewed all three.

Thanks for the reviews! Added Fix Requests to all of them.

>
> Thanks,
> Paul
>
> -----Original Message-----
> From: Alex Kashchenko <akashche at redhat.com>
> Date: Saturday, April 24, 2021 at 6:16 AM
> To: "Hohensee, Paul" <hohensee at amazon.com>
> Cc: "jdk8u-dev at openjdk.java.net" <jdk8u-dev at openjdk.java.net>
> Subject: RE: [8u] RFR: 8256818: SSLSocket that is never bound or connected
> leaks socket resources
>
> On 4/22/21, Hohensee, Paul <hohensee at amazon.com> wrote:
>> You're correct, there's no overlap. Looks fine.
>
> Thanks for the review!
>
>>
>> 11u contains 3 separate follow-up backports, so it would be best to do
>> the
>> same for 8u.
>
> Posted these three backports for review:
>
> https://mail.openjdk.java.net/pipermail/jdk8u-dev/2021-April/013712.html
> https://mail.openjdk.java.net/pipermail/jdk8u-dev/2021-April/013713.html
> https://mail.openjdk.java.net/pipermail/jdk8u-dev/2021-April/013714.html
>
>
>>
>> Thanks,
>> Paul
>>
>> -----Original Message-----
>> From: Alex Kashchenko <akashche at redhat.com>
>> Date: Tuesday, April 20, 2021 at 12:57 PM
>> To: "Hohensee, Paul" <hohensee at amazon.com>
>> Cc: "jdk8u-dev at openjdk.java.net" <jdk8u-dev at openjdk.java.net>
>> Subject: RE: [8u] RFR: 8256818: SSLSocket that is never bound or
>> connected
>> leaks socket resources
>>
>> Hi,
>>
>> On 4/15/21, Alex Kashchenko <akashche at redhat.com> wrote:
>>> On 4/15/21, Hohensee, Paul <hohensee at amazon.com> wrote:
>>>> This patch needs updating. E.g., the IOException catch code in
>>>> SocketImpl.java is already in 8u.
>>>
>>> Thanks for your comments! I will revisit the patch and prepare the
>>> updated version shortly.
>>
>> I've re-checked that the patch can be applied to the latest 8u-dev, it
>> appeared that recent IOException changes do not overlap with it.
>>
>> In mainline this patch required 3 follow-up commits with minor fixes
>> to the test. I've combined these patches into one 8u backport and
>> posted it for review here:
>>
>> https://mail.openjdk.java.net/pipermail/jdk8u-dev/2021-April/013678.html
>>
>> I think it will make sense to push this backport together with the
>> follow-up one.
>>
>>
>>>
>>>>
>>>> Thanks,
>>>> Paul
>>>>
>>>> -----Original Message-----
>>>> From: jdk8u-dev <jdk8u-dev-retn at openjdk.java.net> on behalf of Alex
>>>> Kashchenko <akashche at redhat.com>
>>>> Date: Monday, January 4, 2021 at 2:11 PM
>>>> To: "jdk8u-dev at openjdk.java.net" <jdk8u-dev at openjdk.java.net>
>>>> Subject: [8u] RFR: 8256818: SSLSocket that is never bound or connected
>>>> leaks
>>>> socket resources
>>>>
>>>> Hi,
>>>>
>>>> Please review the backport of JDK-8256818 to 8u:
>>>>
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8256818
>>>>
>>>> Original change: https://github.com/openjdk/jdk/commit/93b6ab56
>>>>
>>>> 11u change:
>>>> https://hg.openjdk.java.net/jdk-updates/jdk11u-dev/rev/8f9ce4460636
>>>>
>>>> Some details on current 11u behaviour (also applicable to 8u):
>>>> https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2020-December/004507.html
>>>>
>>>> 8u webrev: https://cr.openjdk.java.net/~akasko/jdk8u/8256818/webrev.00/
>>>>
>>>> Code change to SSLSocketImpl.java applies cleanly after path change.
>>>> SSLSocketLeak.java test needs to be adapted for 8u: to get the number
>>>> of process handles on Windows native lib is required; there is no
>>>> support for building native test libs in 8u, because of this
>>>> libFileUtils.c is placed into the same directory where test is; test
>>>> is marked as "manual" and "native" and comment with details about
>>>> shared lib is added to the test; test is adapted to load shared lib
>>>> directly without going through FileUtils; changes to CheckHandles.java
>>>> are not applicable to 8u, because corresponding change JDK-8239893 is
>>>> not in 8u.
>>>>
>>>> Testing: checked that added test passes on Linux and Windows, ran
>>>> jtreg:jdk/sun/security/ssl/ and jck:api/javax_net/ssl .
>>>>
>>>> --
>>>> -Alex
>>>>
>>>>
>>>>
>>>
>>>
>>> --
>>> -Alex
>>>
>>
>>
>> --
>> -Alex
>>
>>
>>
>
>
> --
> -Alex
>
>
>


-- 
-Alex