[8u] RFR: 8156584: Initialization race in sun.security.x509.AlgorithmId.get

[Sergey Chernyshev]

Dear colleauges,

Here's an 8u backport identical to the one proposed by Martin Buchholz
in 2016 here [1].
It got approved in [2], but hasn't been pushed.

original fix:
  https://bugs.openjdk.java.net/browse/JDK-8156584
  http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/d7e0283a937c

8u webrev:
  http://cr.openjdk.java.net/~alexsch/sercher/8156584.8u/webrev.00/

The patch applies almost cleanly except for the paths need unshuffling
and a difference in the removed code (new HashMap<> needs explicit
generic parameters).

Testing: compact3, needs_jdk, needs_jre, jdk_security test groups were run.
No regressions observed.

Thanks,
Sergey

[1] https://bugs.openjdk.java.net/browse/JDK-8157190
[2] http://mail.openjdk.java.net/pipermail/security-dev/2016-May/013899.html

On 4/28/2021 5:50 PM, Sergey Chernyshev wrote:
> Hi Andy,
>
> I see no reason why this should not be backported as it solves the race
> condition. I'm going to take it for a spin and propose the backport when
> ready.
>
> Thanks,
> Sergey
>
> On 4/28/2021 1:35 PM, Andy Wilkinson wrote:
>> Hello,
>>
>> I am a maintainer of Spring Boot and a recent change to our CI environment resulted in us being affected [1] by JDK-8156584 [2]. We have worked 
around the problem [3] but were wondering if the possible back port of the fix to JDK 8, which is being tracked by JDK-8157190 [4], could be rekindled?
>>
>> Thanks,
>> Andy
>>
>> [1] https://github.com/spring-projects/spring-boot/issues/26252
>> [2] https://bugs.openjdk.java.net/browse/JDK-8156584
>> [3] https://github.com/spring-projects/spring-boot/commit/912c82e50de096ff35ce31910ea8388298b0193e
>> [4] https://bugs.openjdk.java.net/browse/JDK-8157190

-- 
Best regards,
Sergey Chernyshev
Bellsoft LLC