[8u] RFR: 8226806: [macOS 10.14] Methods of Java Robot should be called from appropriate thread

[Vladimir Kempik]

Hello

Sorry for late response, was awaiting for  JDK-8267545 to appear in 8u-dev.

8155740 is not applying cleanly to 8u-dev, and contains fixes to parts which are missing in ojdk8,
for example CRobotKeyCode.m

So I guess it’s better to proceed with 8226806 without the two fixes you mentioned, as the effect they might give ( clean applying of 8226806) doesn’t worth the hustle they bring.

Regards, Vladimir.
> 9 июня 2021 г., в 20:18, Andrew Hughes <gnu.andrew at redhat.com> написал(а):
> 
> On 11:25 Wed 09 Jun     , Vladimir Kempik wrote:
>> Hello
>> Please review this backport of 8226806.
>> It wasn’t applying cleanly due to context code changes, also smart part of newer testlibrary were needed.
>> Since the support for xcode12 were approved ( see JDK-8267545 ), it becomes important to backport some of the bug fixes as well.
>> This fix passed all the testing in zulu8 for past 3 releases ( since October 2020)
>> 
>> The webrev doesn’t reflect white space changes in CRobot.m, so the patch looks smaller than original.
>> 
>> The webrev: http://cr.openjdk.java.net/~vkempik/8226806/webrev.01/
>> The bug: https://bugs.openjdk.java.net/browse/JDK-8226806
>> The orignal patch: https://hg.openjdk.java.net/jdk/jdk/rev/23dc143cca50 <https://hg.openjdk.java.net/jdk/jdk/rev/23dc143cca50>
>> 
>> Thanks in advance, Vladimir.
> 
> Regarding bug fixes, would it be worth bringing in JDK-8155740 &
> JDK-8156460? I believe these would remove the differences in the
> keyEvent code.
> 
> The test library additions seem odd, given those methods are
> already in jdk/test/lib/jdk/test/lib/process/OutputAnalyzer.java.
> I don't know why we have two OutputAnalyzer.java files, but that
> also seems to be true in 11u!
> 
> Thanks,
> --
> Andrew :)
> 
> Senior Free Java Software Engineer
> OpenJDK Package Owner
> Red Hat, Inc. (http://www.redhat.com)
> 
> PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
> Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222