Re: 回复: [8u] RFR 8264752: SIGFPE crash with option FlightRecorderOptions:threadbuffersize=30M

[Hohensee, Paul]

I'll sponsor. Pushed.

Paul

-----Original Message-----
From: "kalinshi(施慧)" <kalinshi at tencent.com>
Date: Wednesday, August 11, 2021 at 12:47 AM
To: "Hohensee, Paul" <hohensee at amazon.com>, "jdk8u-dev at openjdk.java.net" <jdk8u-dev at openjdk.java.net>
Subject: 回复: [8u] RFR 8264752: SIGFPE crash with option FlightRecorderOptions:threadbuffersize=30M

May I have sponsor for this patch?

Original 8u Webrev crosses hotspot and jdk repository http://cr.openjdk.java.net/~hshi/8264752/webrev_total/
Review information and comments are updated, and Webrev is split into two webrevs.

http://cr.openjdk.java.net/~hshi/8264752/final/jdk.webrev/
http://cr.openjdk.java.net/~hshi/8264752/final/hotspot.webrev/

Regards
Hui

-----邮件原件-----
发件人: Hohensee, Paul <hohensee at amazon.com>
发送时间: 2021年6月28日 23:19
收件人: kalinshi(施慧) <kalinshi at tencent.com>; jdk8u-dev at openjdk.java.net
主题: [Internet]Re: [8u] RFR 8264752: SIGFPE crash with option FlightRecorderOptions:threadbuffersize=30M

Lgtm.

Thanks,
Paul

-----Original Message-----
From: jdk8u-dev <jdk8u-dev-retn at openjdk.java.net> on behalf of "kalinshi(施慧)" <kalinshi at tencent.com>
Date: Sunday, June 27, 2021 at 10:47 PM
To: "jdk8u-dev at openjdk.java.net" <jdk8u-dev at openjdk.java.net>
Subject: [8u] RFR 8264752: SIGFPE crash with option FlightRecorderOptions:threadbuffersize=30M

Please help review JDK-8264752 backport to jdk8u-dev. This PR is already backported to jdk11u.

The original patch does not apply cleanly, conflicts are:
- ClassFileInstaller doesn't need full name in TestBadOptionValues.java (same conflict in jdk11u)
- Change "log_error(arguments)" to "tty->print_cr" in JfrOptionSet::adjust_memory_options

Original bug: https://bugs.openjdk.java.net/browse/JDK-8264752
Original patch: https://git.openjdk.java.net/jdk/commit/377b3461

8u webrev: crosses hotspot and jdk repository http://cr.openjdk.java.net/~hshi/8264752/webrev_total/

Test: jdk_jfr with fastdebug/release build pass

Regards
Hui