[8u] [RFR] JDK-8272214: Build failure after backport of JDK-8248901

[Severin Gehwolf]

On Tue, 2021-08-10 at 18:28 +0100, Andrew Hughes wrote:
> Bug: https://bugs.openjdk.java.net/browse/JDK-8272214
> Webrev:
> https://cr.openjdk.java.net/~andrew/openjdk8/8272214/webrev.01/
> 
> The backport of JDK-8248901 introduced the use of the INT64_C and
> UINT64_C macros from stdint.h to create constants of 64-bit types.
> 
> In C99, it was required that these macros only be defined in C++ when
> __STDC_CONSTANT_MACROS was defined. This requirement was dropped with
> C11. Older versions of glibc conform with C99 and only define them
> when this __STDC_CONSTANT_MACROS is defined.  Newer versions conform
> with C11 and always define them [0], which is why the build only
> fails
> on older platforms.
> 
> I presume the case is similar for Windows, but I don't have such an
> environment to check. Severin has confirmed that defining
> __STDC_CONSTANT_MACROS does fix the build on both platforms. [1]
> 
> Ok for 8u-dev?

Hi Andrew,

Please hold this patch for a bit longer since we are still seeing
Windows build failures with VS 2010 with this patch. More work will be
needed. It's not clear why the Adopt CI worked. One difference is VS
2013 build vs. VS 2010 build, apparently.

Thanks,
Severin

> [0] https://sourceware.org/bugzilla/show_bug.cgi?id=15366
> [1] https://mail.openjdk.java.net/pipermail/jdk8u-dev/2021-August/014175.html