[8u] RFR (S) 8272714: [8u] Build failure after backport of JDK-8248901 with MSVC 2013

Aleksey Shipilev shade at redhat.com
Thu Aug 19 11:35:44 UTC 2021


8u-specific bug:
   https://bugs.openjdk.java.net/browse/JDK-8272714

Previous fix (JDK-8272214) handled MSVC 2010, but my build servers that run MSVC 2013 also fail with 
the same error message. Here is the fix that replaces the MSVC version check by replacing with the 
actual definition test.

Testing: building with MSVC 2010 and MSVC 2013

8272714: [8u] Build failure after backport of JDK-8248901 with MSVC 2013
Summary: Relax the check to accept more MSVC versions
Reviewed-by: XXX

diff -r 21394894714b -r 0a9dbaad59a4 src/share/vm/utilities/globalDefinitions_visCPP.hpp
--- a/src/share/vm/utilities/globalDefinitions_visCPP.hpp       Wed Aug 18 11:17:04 2021 +0200
+++ b/src/share/vm/utilities/globalDefinitions_visCPP.hpp       Thu Aug 19 13:22:23 2021 +0200
@@ -77,10 +77,12 @@
  // pointer is stored as integer value.
  #define NULL_WORD NULL

-// MS Visual Studio 10 doesn't seem to have INT64_C and UINT64_C even with
+// MS Visual Studio 10 and 13 do not seem to have INT64_C and UINT64_C even with
  // __STDC_CONSTANT_MACROS defined.
-#if _MSC_VER <= 1600
+#ifndef INT64_C
  #define INT64_C(c)  (c ## i64)
+#endif
+#ifndef UINT64_C
  #define UINT64_C(c) (c ## ui64)
  #endif



-- 
Thanks,
-Aleksey



More information about the jdk8u-dev mailing list