[8u] RFR (S) 8272714: [8u] Build failure after backport of JDK-8248901 with MSVC 2013

Aleksey Shipilev shade at redhat.com
Fri Aug 20 09:53:40 UTC 2021


On 8/20/21 11:49 AM, Severin Gehwolf wrote:
> On Fri, 2021-08-20 at 11:30 +0200, Aleksey Shipilev wrote:
>> Thanks. Like this?
>>
>> diff -r 21394894714b src/share/vm/utilities/globalDefinitions_visCPP.hpp
>> --- a/src/share/vm/utilities/globalDefinitions_visCPP.hpp       Wed Aug 18 11:17:04 2021 +0200
>> +++ b/src/share/vm/utilities/globalDefinitions_visCPP.hpp       Fri Aug 20 11:29:08 2021 +0200
>> @@ -78,8 +78,10 @@
>>    #define NULL_WORD NULL
>>
>> -// MS Visual Studio 10 doesn't seem to have INT64_C and UINT64_C even with
>> -// __STDC_CONSTANT_MACROS defined.
>> -#if _MSC_VER <= 1600
>> +// Some MS Visual Studio versions do not seem to have INT64_C and UINT64_C
>> +// even with __STDC_CONSTANT_MACROS defined.
>> +#ifndef INT64_C
>>    #define INT64_C(c)  (c ## i64)
>> +#endif
>> +#ifndef UINT64_C
>>    #define UINT64_C(c) (c ## ui64)
>>    #endif
> 
> That seems fine. Please flag for approval.

Tagged. I'll wait for Andrew Hughes to approve?

-- 
Thanks,
-Aleksey



More information about the jdk8u-dev mailing list