RFR: [8u] JDK-8022323 "[JavaSecurityScanner] review package com.sun.management.* Native methods should be private

Andrew Hughes gnu.andrew at redhat.com
Wed Aug 25 04:18:44 UTC 2021


On 11:58 Tue 24 Aug     , Severin Gehwolf wrote:
> On Tue, 2021-08-24 at 05:40 +0100, Andrew Hughes wrote:
> > On 05:37 Tue 24 Aug     , Andrew Hughes wrote:
> > > Bug: Inaccessible
> > > Webrev: https://cr.openjdk.java.net/~andrew/openjdk8/8022323/webrev.01/
> 
> make/mapfiles/libmanagement/mapfile-vers:
> 
> -	    Java_sun_management_OperatingSystemImpl_getSingleCpuLoad0;
>  	    Java_sun_management_OperatingSystemImpl_getHostConfiguredCpuCount0;
> 
> Removal of getSingleCpuLoad0 from the map file seems incorrect.
> 
> Otherwise, the patch looks fine.
> 
> Thanks,
> Severin
> 

Weird. I must have mis-read it as SystemCpuLoad0 and thought it was
a duplicate.  Good catch.

Fixed in https://cr.openjdk.java.net/~andrew/openjdk8/8022323/webrev.02/
-- 
Andrew :)
Pronouns: he / him or they / them
Senior Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222


More information about the jdk8u-dev mailing list