From gnu.andrew at redhat.com  Wed Dec  1 17:35:32 2021
From: gnu.andrew at redhat.com (Andrew Hughes)
Date: Wed, 1 Dec 2021 17:35:32 +0000
Subject: [8u] RFA: 8162572: Update License Header for all JAXP sources
In-Reply-To: <CABUxsJ3G4R8M_Pn9bGW8Mm_0cQEymweEB6o=VkR3Zxt+AATPwA@mail.gmail.com>
References: <CABUxsJ1YGFqAvEKxi+G8JTY0KS6CD6VuKexYF0yE=_n8KjDVfA@mail.gmail.com>
 <CABUxsJ3G4R8M_Pn9bGW8Mm_0cQEymweEB6o=VkR3Zxt+AATPwA@mail.gmail.com>
Message-ID: <YaeyZG2ctLIHpEZx@hex.discworld.ac.uk>

On 16:07 Wed 24 Nov     , Alex Kashchenko wrote:
> On 10/15/21, Alex Kashchenko <akashche at redhat.com> wrote:
> > Hi,
> >
> > JDK-8162572 is not public, so requesting the approval here:
> >
> > Fix request (8u)
> >
> > Backport is requested because it can make it easier to backport
> > subsequent JAXP parity
> > issues to 8u (don't have a comprehensive list, intend to proceed with
> > JDK-8163121 first).
> >
> > Review approval:
> >
> > https://mail.openjdk.java.net/pipermail/jdk8u-dev/2021-October/014353.html
> 
> Gentle reminder just to increase the visibility of this request, that
> is not visible in Jira approval queue because the issue is not public.
> 
> 
> -- 
> -Alex
> 

Sorry, only saw this today. Looks fine to me. Please rebase and push
to monojdk8u-dev for 8u332 once the repos are re-opened (waiting on
confirmation of the bug resolution being updated from ops)

Thanks,
-- 
Andrew :)
Pronouns: he / him or they / them
Senior Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222

From zgu at redhat.com  Wed Dec  1 18:58:20 2021
From: zgu at redhat.com (Zhengyu Gu)
Date: Wed, 1 Dec 2021 13:58:20 -0500
Subject: [8u] RFR 8277224: sun.security.pkcs.PKCS9Attributes.toString() throws
 NPE
Message-ID: <f88b7e07-c32a-bd5f-2874-b65eec9e9b45@redhat.com>

I would like to backport this patch to openjdk8u for parity with Oracle 
8u331.

Bug: https://bugs.openjdk.java.net/browse/JDK-8277224
Patch: 
https://github.com/openjdk/jdk/commit/6bb04626af6574ef1e8d4b7dad0389d4b59f5d08

The original patch does not apply cleanly to 8u. The only conflict is 
the change in PKCS9Attributes.toString() method, where 8u uses 
"StringBuffer buf", while 18 uses "StringBuffer sb" to build string.

8u webrev: http://cr.openjdk.java.net/~zgu/JDK-8277224-8u/webrev.00/

Test:
   NonStandardNames.java passed.


Thanks,

-Zhengyu


From hohensee at amazon.com  Wed Dec  1 20:32:37 2021
From: hohensee at amazon.com (Hohensee, Paul)
Date: Wed, 1 Dec 2021 20:32:37 +0000
Subject: [8u] RFR 8277224: sun.security.pkcs.PKCS9Attributes.toString()
 throws NPE
Message-ID: <0EAD9AD1-4394-4E6D-A38E-AA22C6D55B55@amazon.com>

Lgtm.

Thanks,
Paul

?-----Original Message-----
From: jdk8u-dev <jdk8u-dev-retn at openjdk.java.net> on behalf of Zhengyu Gu <zgu at redhat.com>
Date: Wednesday, December 1, 2021 at 11:00 AM
To: jdk8u-dev <jdk8u-dev at openjdk.java.net>
Subject: [8u] RFR 8277224: sun.security.pkcs.PKCS9Attributes.toString() throws NPE

I would like to backport this patch to openjdk8u for parity with Oracle
8u331.

Bug: https://bugs.openjdk.java.net/browse/JDK-8277224
Patch:
https://github.com/openjdk/jdk/commit/6bb04626af6574ef1e8d4b7dad0389d4b59f5d08

The original patch does not apply cleanly to 8u. The only conflict is
the change in PKCS9Attributes.toString() method, where 8u uses
"StringBuffer buf", while 18 uses "StringBuffer sb" to build string.

8u webrev: http://cr.openjdk.java.net/~zgu/JDK-8277224-8u/webrev.00/

Test:
   NonStandardNames.java passed.


Thanks,

-Zhengyu



From zgu at redhat.com  Wed Dec  1 20:40:39 2021
From: zgu at redhat.com (Zhengyu Gu)
Date: Wed, 1 Dec 2021 15:40:39 -0500
Subject: [8u] RFR 8277224: sun.security.pkcs.PKCS9Attributes.toString()
 throws NPE
In-Reply-To: <0EAD9AD1-4394-4E6D-A38E-AA22C6D55B55@amazon.com>
References: <0EAD9AD1-4394-4E6D-A38E-AA22C6D55B55@amazon.com>
Message-ID: <9844ab96-124e-a2f5-defd-101473adcf5b@redhat.com>

Thanks for the review, Paul.

-Zhengyu

On 12/1/21 15:32, Hohensee, Paul wrote:
> Lgtm.
> 
> Thanks,
> Paul
> 
> ?-----Original Message-----
> From: jdk8u-dev <jdk8u-dev-retn at openjdk.java.net> on behalf of Zhengyu Gu <zgu at redhat.com>
> Date: Wednesday, December 1, 2021 at 11:00 AM
> To: jdk8u-dev <jdk8u-dev at openjdk.java.net>
> Subject: [8u] RFR 8277224: sun.security.pkcs.PKCS9Attributes.toString() throws NPE
> 
> I would like to backport this patch to openjdk8u for parity with Oracle
> 8u331.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8277224
> Patch:
> https://github.com/openjdk/jdk/commit/6bb04626af6574ef1e8d4b7dad0389d4b59f5d08
> 
> The original patch does not apply cleanly to 8u. The only conflict is
> the change in PKCS9Attributes.toString() method, where 8u uses
> "StringBuffer buf", while 18 uses "StringBuffer sb" to build string.
> 
> 8u webrev: http://cr.openjdk.java.net/~zgu/JDK-8277224-8u/webrev.00/
> 
> Test:
>     NonStandardNames.java passed.
> 
> 
> Thanks,
> 
> -Zhengyu
> 
> 


From akashche at redhat.com  Wed Dec  1 21:15:42 2021
From: akashche at redhat.com (Alex Kashchenko)
Date: Wed, 1 Dec 2021 21:15:42 +0000
Subject: [8u] RFA: 8162572: Update License Header for all JAXP sources
In-Reply-To: <YaeyZG2ctLIHpEZx@hex.discworld.ac.uk>
References: <CABUxsJ1YGFqAvEKxi+G8JTY0KS6CD6VuKexYF0yE=_n8KjDVfA@mail.gmail.com>
 <CABUxsJ3G4R8M_Pn9bGW8Mm_0cQEymweEB6o=VkR3Zxt+AATPwA@mail.gmail.com>
 <YaeyZG2ctLIHpEZx@hex.discworld.ac.uk>
Message-ID: <CABUxsJ3GxF_T384QzXnYmfW57Gf_uforNdwj+rW7sVzK8HrsHQ@mail.gmail.com>

On 12/1/21, Andrew Hughes <gnu.andrew at redhat.com> wrote:
> On 16:07 Wed 24 Nov     , Alex Kashchenko wrote:
>> On 10/15/21, Alex Kashchenko <akashche at redhat.com> wrote:
>> > Hi,
>> >
>> > JDK-8162572 is not public, so requesting the approval here:
>> >
>> > Fix request (8u)
>> >
>> > Backport is requested because it can make it easier to backport
>> > subsequent JAXP parity
>> > issues to 8u (don't have a comprehensive list, intend to proceed with
>> > JDK-8163121 first).
>> >
>> > Review approval:
>> >
>> > https://mail.openjdk.java.net/pipermail/jdk8u-dev/2021-October/014353.html
>>
>> Gentle reminder just to increase the visibility of this request, that
>> is not visible in Jira approval queue because the issue is not public.
>>
>>
>> --
>> -Alex
>>
>
> Sorry, only saw this today. Looks fine to me. Please rebase and push
> to monojdk8u-dev for 8u332 once the repos are re-opened (waiting on
> confirmation of the bug resolution being updated from ops)

Thanks for the approval! I will push it when monorepo is open.


-- 
-Alex


From zgu at redhat.com  Thu Dec  2 14:45:57 2021
From: zgu at redhat.com (Zhengyu Gu)
Date: Thu, 2 Dec 2021 09:45:57 -0500
Subject: [8u] RFR 8253353: Crash in C2: guarantee(n != NULL) failed: No Node
Message-ID: <74cad439-f1fb-b2c1-087c-785fdf92b025@redhat.com>

I would like to backport this patch to openjdk8u for parity with Oracle 
8u331. The patch fixes a fatal crash initially reported for openjdk8u, 
so it should be backported.

Bug: https://bugs.openjdk.java.net/browse/JDK-8253353

The backport is based on jdk11u backport, which is closer to 8u.
Patch: https://hg.openjdk.java.net/jdk-updates/jdk11u/rev/04682d78ae28

The patch still does not apply cleanly.
- 8u does not have PhaseIdealLoop::create_outer_strip_mined_loop() 
method, stripped corresponding change in the method.
- Slight context different in IdealLoopTree declaration.


8u webrev: http://cr.openjdk.java.net/~zgu/JDK-8253353-8u/webrev.00/

Test:
   passed compiler/loopopts/TestNestedIrreducibleLoopsMain.java test

Thanks,

-Zhengyu


From gnu.andrew at redhat.com  Thu Dec  2 17:26:11 2021
From: gnu.andrew at redhat.com (Andrew Hughes)
Date: Thu, 2 Dec 2021 17:26:11 +0000
Subject: [IMPORTANT] 8u & 8u-dev Mono Repositories Now Open
Message-ID: <YakBs8He+Rz+3AFX@hex.discworld.ac.uk>

For 8u332 changes with jdk8u-fix-yes, you can now push to:

https://hg.openjdk.java.net/jdk8u/monojdk8u-dev

For critical changes for the upcoming 8u322 release in January with
jdk8u-critical-yes, you can now push to:

https://hg.openjdk.java.net/jdk8u/monojdk8u

Note: these repositories are not related to the old 8u forest
repositories and you will need to perform a clean checkout.

The 8u wiki should now be up-to-date with the new repository
details, but please let me know if any inaccuracies remain.

The process for 8u for now remains the same, other than
the use of the new repositories.

For those who only need read-only access, we now have live
git mirrors on GitHub:

https://github.com/openjdk/jdk8u
https://github.com/openjdk/jdk8u-dev

8u-dev development will move to Git+Skara at the end of February next
year, so please familarise yourself with their use on later JDK
versions in the meantime to prepare for that switchover.

Thanks,
-- 
Andrew :)
Pronouns: he / him or they / them
Senior Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222

From gnu.andrew at redhat.com  Thu Dec  2 17:27:20 2021
From: gnu.andrew at redhat.com (Andrew Hughes)
Date: Thu, 2 Dec 2021 17:27:20 +0000
Subject: [8u] RFR 8277224: sun.security.pkcs.PKCS9Attributes.toString()
 throws NPE
In-Reply-To: <f88b7e07-c32a-bd5f-2874-b65eec9e9b45@redhat.com>
References: <f88b7e07-c32a-bd5f-2874-b65eec9e9b45@redhat.com>
Message-ID: <YakB+O3Xs60gHWul@hex.discworld.ac.uk>

On 13:58 Wed 01 Dec     , Zhengyu Gu wrote:
> I would like to backport this patch to openjdk8u for parity with Oracle 
> 8u331.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8277224
> Patch: 
> https://github.com/openjdk/jdk/commit/6bb04626af6574ef1e8d4b7dad0389d4b59f5d08
> 
> The original patch does not apply cleanly to 8u. The only conflict is 
> the change in PKCS9Attributes.toString() method, where 8u uses 
> "StringBuffer buf", while 18 uses "StringBuffer sb" to build string.
> 
> 8u webrev: http://cr.openjdk.java.net/~zgu/JDK-8277224-8u/webrev.00/
> 
> Test:
>    NonStandardNames.java passed.
> 
> 
> Thanks,
> 
> -Zhengyu
> 

This webrev still seems to be based on the old 8u repositories.

Changes now need to be against https://hg.openjdk.java.net/jdk8u/monojdk8u-dev

Thanks,
-- 
Andrew :)
Pronouns: he / him or they / them
Senior Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222

From shade at redhat.com  Fri Dec  3 06:41:15 2021
From: shade at redhat.com (Aleksey Shipilev)
Date: Fri, 3 Dec 2021 07:41:15 +0100
Subject: [IMPORTANT] 8u & 8u-dev Mono Repositories Now Open
In-Reply-To: <YakBs8He+Rz+3AFX@hex.discworld.ac.uk>
References: <YakBs8He+Rz+3AFX@hex.discworld.ac.uk>
Message-ID: <506a34d7-56b8-4226-74bf-c4c8d235681a@redhat.com>

On 12/2/21 6:26 PM, Andrew Hughes wrote:
> https://hg.openjdk.java.net/jdk8u/monojdk8u-dev
> https://hg.openjdk.java.net/jdk8u/monojdk8u
> 
> Note: these repositories are not related to the old 8u forest
> repositories and you will need to perform a clean checkout.

As usual, if you have problems checking out these repos, their snapshots are here:
   https://builds.shipilev.net/workspaces/

-- 
Thanks,
-Aleksey


From rwestrel at redhat.com  Fri Dec  3 13:11:03 2021
From: rwestrel at redhat.com (Roland Westrelin)
Date: Fri, 03 Dec 2021 14:11:03 +0100
Subject: [8u] RFR 8253353: Crash in C2: guarantee(n != NULL) failed: No
 Node
In-Reply-To: <74cad439-f1fb-b2c1-087c-785fdf92b025@redhat.com>
References: <74cad439-f1fb-b2c1-087c-785fdf92b025@redhat.com>
Message-ID: <87mtlhkf4o.fsf@redhat.com>


> 8u webrev: http://cr.openjdk.java.net/~zgu/JDK-8253353-8u/webrev.00/

Looks good to me.

Roland.


From zgu at redhat.com  Fri Dec  3 15:10:24 2021
From: zgu at redhat.com (Zhengyu Gu)
Date: Fri, 3 Dec 2021 10:10:24 -0500
Subject: [8u] RFR 8253353: Crash in C2: guarantee(n != NULL) failed: No
 Node
In-Reply-To: <74cad439-f1fb-b2c1-087c-785fdf92b025@redhat.com>
References: <74cad439-f1fb-b2c1-087c-785fdf92b025@redhat.com>
Message-ID: <da923d61-36d8-e5ea-985a-2e5b7fbbea09@redhat.com>

Rebased to monojdk8u:

http://cr.openjdk.java.net/~zgu/JDK-8253353-8u/webrev.01/

Thanks,

-Zhengyu

On 12/2/21 09:45, Zhengyu Gu wrote:
> I would like to backport this patch to openjdk8u for parity with Oracle 
> 8u331. The patch fixes a fatal crash initially reported for openjdk8u, 
> so it should be backported.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8253353
> 
> The backport is based on jdk11u backport, which is closer to 8u.
> Patch: https://hg.openjdk.java.net/jdk-updates/jdk11u/rev/04682d78ae28
> 
> The patch still does not apply cleanly.
> - 8u does not have PhaseIdealLoop::create_outer_strip_mined_loop() 
> method, stripped corresponding change in the method.
> - Slight context different in IdealLoopTree declaration.
> 
> 
> 8u webrev: http://cr.openjdk.java.net/~zgu/JDK-8253353-8u/webrev.00/
> 
> Test:
>  ? passed compiler/loopopts/TestNestedIrreducibleLoopsMain.java test
> 
> Thanks,
> 
> -Zhengyu


From zgu at redhat.com  Fri Dec  3 15:34:46 2021
From: zgu at redhat.com (Zhengyu Gu)
Date: Fri, 3 Dec 2021 10:34:46 -0500
Subject: [8u] RFR 8253353: Crash in C2: guarantee(n != NULL) failed: No
 Node
In-Reply-To: <87mtlhkf4o.fsf@redhat.com>
References: <74cad439-f1fb-b2c1-087c-785fdf92b025@redhat.com>
 <87mtlhkf4o.fsf@redhat.com>
Message-ID: <41a4151b-5c58-3daf-c930-b103283eff27@redhat.com>

Thanks, Roland.

-Zhengyu

On 12/3/21 08:11, Roland Westrelin wrote:
> 
>> 8u webrev: http://cr.openjdk.java.net/~zgu/JDK-8253353-8u/webrev.00/
> 
> Looks good to me.
> 
> Roland.
> 


From zgu at redhat.com  Fri Dec  3 19:23:53 2021
From: zgu at redhat.com (Zhengyu Gu)
Date: Fri, 3 Dec 2021 14:23:53 -0500
Subject: [8u] RFR 8277224: sun.security.pkcs.PKCS9Attributes.toString()
 throws NPE
In-Reply-To: <YakB+O3Xs60gHWul@hex.discworld.ac.uk>
References: <f88b7e07-c32a-bd5f-2874-b65eec9e9b45@redhat.com>
 <YakB+O3Xs60gHWul@hex.discworld.ac.uk>
Message-ID: <ed2beef4-e43c-4a5d-fd94-5d3daeae3813@redhat.com>

> 
> This webrev still seems to be based on the old 8u repositories.
> 
> Changes now need to be against https://hg.openjdk.java.net/jdk8u/monojdk8u-dev

Rebased: http://cr.openjdk.java.net/~zgu/JDK-8277224-8u/webrev.01/

Thanks,

-Zhengyu

> 
> Thanks,
> 


From dcherepanov at azul.com  Mon Dec  6 09:47:53 2021
From: dcherepanov at azul.com (Dmitry Cherepanov)
Date: Mon, 6 Dec 2021 12:47:53 +0300
Subject: [8u] RFR: JDK-8275766: (tz) Update Timezone Data to 2021e
In-Reply-To: <75d3cea8-9556-7008-a255-e1fea5aa3fe5@azul.com>
References: <f8979470-00dc-563e-cd10-9f441dd56460@azul.com>
 <03e3e2c4aacae2b85bbde8b078a93700a6e7712f.camel@redhat.com>
 <65ba0eed-bbc5-22be-9f38-3beddefd711e@azul.com>
 <YaWb3aLdspO08r1A@hex.discworld.ac.uk>
 <75d3cea8-9556-7008-a255-e1fea5aa3fe5@azul.com>
Message-ID: <a74446d1-93dd-9302-5647-46367e183bca@azul.com>

On 30.11.2021 10:08, Dmitry Cherepanov wrote:
>
> On 30.11.2021 06:34, Andrew Hughes wrote:
>> Please tag these as jdk8u-critical-request for 8u322. I don't see any
>> need to delay this to April.
>
> Tagged as jdk8u-critical-request.

Rebased versions (on https://hg.openjdk.java.net/jdk8u/monojdk8u)

https://cr.openjdk.java.net/~dcherepanov/openjdk8u/8275766/webrev.02/
https://cr.openjdk.java.net/~dcherepanov/openjdk8u/8276536/webrev.02/

Sanity checked that it builds and relevant tests pass.

Thanks

Dmitry

From sgehwolf at redhat.com  Fri Dec 10 14:02:42 2021
From: sgehwolf at redhat.com (Severin Gehwolf)
Date: Fri, 10 Dec 2021 15:02:42 +0100
Subject: [8u] RFR: 8202822: Add .git to .hgignore
In-Reply-To: <63aa6024c897e15708d8b5dba2fde573460eb0d8.camel@redhat.com>
References: <63aa6024c897e15708d8b5dba2fde573460eb0d8.camel@redhat.com>
Message-ID: <c1c10aea80cdb86cadc4ce25f7ac1ed55801f867.camel@redhat.com>

Re-send. Hopefully it'll reach the mailing list this time around
(supposedly there was an outage).

On Thu, 2021-12-09 at 17:26 +0100, Severin Gehwolf wrote:
> Hi,
> 
> With the Git mirrors now live, lets add .git to th HG's ignore file.
> Trivial patch, which didn't apply cleanly due to context differences.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8202822
> webrev: https://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8202822/01/webrev/
> 
> Thoughts?
> 
> Thanks,
> Severin


From sgehwolf at redhat.com  Fri Dec 10 14:11:00 2021
From: sgehwolf at redhat.com (Severin Gehwolf)
Date: Fri, 10 Dec 2021 15:11:00 +0100
Subject: [8u] RFR: 8210283:  Support git as an SCM alternative in the build
Message-ID: <018e4ec4ebaabd486047b9594da773887d53eee2.camel@redhat.com>

Hi,

Please review this adaptation of the corresponding JDK 11 patch. The
JDK 11u patch didn't apply because the build system is widely different
between these two releases.

The main difference is make/common/MakeBase.gmk (JDK 8) vs
make/SourceRevision.gmk (JDK 11). I've basically rewritten those parts
of the patch. All the SCM handling in JDK 8 is in MakeBase.
FindAllReposAbs isn't present in JDK 8u.

Bug: https://bugs.openjdk.java.net/browse/JDK-8210283
webrev: https://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8210283/01/webrev/

Testing: "make --trace source-tips" on mercurial tree as well as
         the git mirror. $IMAGE_DIR/release file contains the SHA of
         the sources it was built from with 'git:' or 'hg:' prefixes.

Thoughts?

Thanks,
Severin


From hohensee at amazon.com  Fri Dec 10 17:56:36 2021
From: hohensee at amazon.com (Hohensee, Paul)
Date: Fri, 10 Dec 2021 17:56:36 +0000
Subject: [8u] RFR: 8202822: Add .git to .hgignore
Message-ID: <E52A86C5-BFB9-4E70-B878-684A4F0CD573@amazon.com>

Lgtm.

Thanks,
Paul

?-----Original Message-----
From: jdk8u-dev <jdk8u-dev-retn at openjdk.java.net> on behalf of Severin Gehwolf <sgehwolf at redhat.com>
Date: Friday, December 10, 2021 at 6:03 AM
To: "jdk8u-dev at openjdk.java.net" <jdk8u-dev at openjdk.java.net>
Subject: Re: [8u] RFR: 8202822: Add .git to .hgignore

Re-send. Hopefully it'll reach the mailing list this time around
(supposedly there was an outage).

On Thu, 2021-12-09 at 17:26 +0100, Severin Gehwolf wrote:
> Hi,
>
> With the Git mirrors now live, lets add .git to th HG's ignore file.
> Trivial patch, which didn't apply cleanly due to context differences.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8202822
> webrev: https://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8202822/01/webrev/
>
> Thoughts?
>
> Thanks,
> Severin



From sgehwolf at redhat.com  Fri Dec 10 18:10:31 2021
From: sgehwolf at redhat.com (Severin Gehwolf)
Date: Fri, 10 Dec 2021 19:10:31 +0100
Subject: [8u] RFR: 8202822: Add .git to .hgignore
In-Reply-To: <E52A86C5-BFB9-4E70-B878-684A4F0CD573@amazon.com>
References: <E52A86C5-BFB9-4E70-B878-684A4F0CD573@amazon.com>
Message-ID: <fd93a9c9b0ba5429dcbe47b95412156ced5b9ef9.camel@redhat.com>

On Fri, 2021-12-10 at 17:56 +0000, Hohensee, Paul wrote:
> Lgtm.
> 

Thanks for the review, Paul!

Cheers,
Severin


From sgehwolf at redhat.com  Mon Dec 13 15:14:06 2021
From: sgehwolf at redhat.com (Severin Gehwolf)
Date: Mon, 13 Dec 2021 16:14:06 +0100
Subject: [8u] RFR 8190753: (zipfs): Accessing a large entry (> 2^31
 bytes) leads to a negative initial size for ByteArrayOutputStream
In-Reply-To: <CH0PR11MB552330D2B65F5A08B0AA68D5C9629@CH0PR11MB5523.namprd11.prod.outlook.com>
References: <CH0PR11MB552330D2B65F5A08B0AA68D5C9629@CH0PR11MB5523.namprd11.prod.outlook.com>
Message-ID: <af6738c9303f847a3c8b7a4aef59824c80aedfe6.camel@redhat.com>

On Thu, 2021-11-25 at 12:23 +0000, Alexey Pavlyutkin wrote:
> Bug: https://bugs.openjdk.java.net/browse/JDK-8190753
> 
> Patch: https://github.com/openjdk/jdk/commit/c3d8e9228d0558a2ce3e093c105c61ea7af2e1d1
> 
> I would like to backport this patch to openjdk8u (the issue was initially raised exactly against 8)
> 
> The following changes done to the original patch for 8u
> 
> 
> ? 1.? eliminated using of unsupported instanceof pattern match feature
> ? 2.? changes to absent DeflatingEntryOutputStream class were skipped (in 8 EntryOutputStream handles both RAW and deflating streaming)
> ? 3.? tests were updated to not use unsupported APIs like Path.of(), Map.of(), etc.
> 
> 8u webrev: http://cr.openjdk.java.net/~yan/8190753/webrev.00/

 .jcheck/conf:

Those changes aren't in the original patch. Where are these coming from?

Thanks,
Severin


From apavlyutkin at azul.com  Mon Dec 13 20:42:28 2021
From: apavlyutkin at azul.com (Alexey Pavlyutkin)
Date: Mon, 13 Dec 2021 20:42:28 +0000
Subject: [8u] RFR 8190753: (zipfs): Accessing a large entry (> 2^31 bytes)
 leads to a negative initial size for ByteArrayOutputStream
In-Reply-To: <af6738c9303f847a3c8b7a4aef59824c80aedfe6.camel@redhat.com>
References: <CH0PR11MB552330D2B65F5A08B0AA68D5C9629@CH0PR11MB5523.namprd11.prod.outlook.com>
 <af6738c9303f847a3c8b7a4aef59824c80aedfe6.camel@redhat.com>
Message-ID: <CH0PR11MB5523A99FA95DA23124661EE5C9749@CH0PR11MB5523.namprd11.prod.outlook.com>

Hi Severin!

I have no idea. I did not do that advisedly. Probably I did them occasionally configuring jcheck tool. Anyway as I understand the changes are to be rebased to monorepo. Should I fix it before rebasing?

Thanks,
Alex

-----Original Message-----
From: Severin Gehwolf <sgehwolf at redhat.com> 
Sent: Monday, December 13, 2021 6:14 PM
To: Alexey Pavlyutkin <apavlyutkin at azul.com>; jdk8u-dev at openjdk.java.net
Subject: Re: [8u] RFR 8190753: (zipfs): Accessing a large entry (> 2^31 bytes) leads to a negative initial size for ByteArrayOutputStream

On Thu, 2021-11-25 at 12:23 +0000, Alexey Pavlyutkin wrote:
> Bug: https://bugs.openjdk.java.net/browse/JDK-8190753
> 
> Patch: https://github.com/openjdk/jdk/commit/c3d8e9228d0558a2ce3e093c105c61ea7af2e1d1
> 
> I would like to backport this patch to openjdk8u (the issue was initially raised exactly against 8)
> 
> The following changes done to the original patch for 8u
> 
> 
> ? 1.? eliminated using of unsupported instanceof pattern match feature
> ? 2.? changes to absent DeflatingEntryOutputStream class were skipped (in 8 EntryOutputStream handles both RAW and deflating streaming)
> ? 3.? tests were updated to not use unsupported APIs like Path.of(), Map.of(), etc.
> 
> 8u webrev: http://cr.openjdk.java.net/~yan/8190753/webrev.00/

 .jcheck/conf:

Those changes aren't in the original patch. Where are these coming from?

Thanks,
Severin


From gnu.andrew at redhat.com  Tue Dec 14 03:20:45 2021
From: gnu.andrew at redhat.com (Andrew Hughes)
Date: Tue, 14 Dec 2021 03:20:45 +0000
Subject: [8u] RFR 8190753: (zipfs): Accessing a large entry (> 2^31
 bytes) leads to a negative initial size for ByteArrayOutputStream
In-Reply-To: <CH0PR11MB5523A99FA95DA23124661EE5C9749@CH0PR11MB5523.namprd11.prod.outlook.com>
References: <CH0PR11MB552330D2B65F5A08B0AA68D5C9629@CH0PR11MB5523.namprd11.prod.outlook.com>
 <af6738c9303f847a3c8b7a4aef59824c80aedfe6.camel@redhat.com>
 <CH0PR11MB5523A99FA95DA23124661EE5C9749@CH0PR11MB5523.namprd11.prod.outlook.com>
Message-ID: <YbgNjUh8/TDYX8MF@hex.discworld.ac.uk>

On 20:42 Mon 13 Dec     , Alexey Pavlyutkin wrote:
> Hi Severin!
> 
> I have no idea. I did not do that advisedly. Probably I did them occasionally configuring jcheck tool. Anyway as I understand the changes are to be rebased to monorepo. Should I fix it before rebasing?
>

Please do.

There are some other issues with the patch:

* The placement of FileRolloverOutputStream seems to occur earlier in
  the 8u patch than in the 11u one. Can you confirm it ends up in the
  same or similar place in the file?

* Map.of creates unmodifiable Map instances. The replacement with emptyMap
is fine, but the others need to be made unmodifiable. See the examples
in jdk/test/sun/security/krb5/auto/KDC.java which was also converted
from Map.of usage.

Please don't flag issues for approval with jdk8u-fix-request until
they have been satisfactorily reviewed on the list.

> Thanks,
> Alex

Thanks,
-- 
Andrew :)
Pronouns: he / him or they / them
Senior Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222

From gnu.andrew at redhat.com  Tue Dec 14 03:22:19 2021
From: gnu.andrew at redhat.com (Andrew Hughes)
Date: Tue, 14 Dec 2021 03:22:19 +0000
Subject: [8u] RFR: 8202822: Add .git to .hgignore
In-Reply-To: <c1c10aea80cdb86cadc4ce25f7ac1ed55801f867.camel@redhat.com>
References: <63aa6024c897e15708d8b5dba2fde573460eb0d8.camel@redhat.com>
 <c1c10aea80cdb86cadc4ce25f7ac1ed55801f867.camel@redhat.com>
Message-ID: <YbgN6+fNQISILJUb@hex.discworld.ac.uk>

On 15:02 Fri 10 Dec     , Severin Gehwolf wrote:
> Re-send. Hopefully it'll reach the mailing list this time around
> (supposedly there was an outage).
> 
> On Thu, 2021-12-09 at 17:26 +0100, Severin Gehwolf wrote:
> > Hi,
> > 
> > With the Git mirrors now live, lets add .git to th HG's ignore file.
> > Trivial patch, which didn't apply cleanly due to context differences.
> > 
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8202822
> > webrev: https://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8202822/01/webrev/
> > 
> > Thoughts?
> > 
> > Thanks,
> > Severin
> 

I've approved this, as I can't see it does any harm, especially given
it's only going to be active for a few months. However, I don't see
what it has to do with the eventual Git transition. When we do start
using git, surely we'll be using .gitignore? Why would there be .git
directories in a Mercurial checkout?

Thanks,
-- 
Andrew :)
Pronouns: he / him or they / them
Senior Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222

From magnus.vojbacke at digitalroute.com  Tue Dec 14 11:51:06 2021
From: magnus.vojbacke at digitalroute.com (Magnus Vojbacke)
Date: Tue, 14 Dec 2021 11:51:06 +0000
Subject: java.security.KeystStore fails to load some PKCS12 stores
Message-ID: <BD61FB3D-7670-439B-B2AA-E5386300909F@digitalroute.com>

We would like java.security.Keystore to be able to load all PKCS12 stores, like in Oracle JDK or the latest version of OpenJDK.

I would love to see an OpenJDK bug on this and subsequent fix for openjdk 8u. Currently, the OpenJDK 8u312 and 8u322(EA) fail to load some PKCS12 certificates. The same certificates can be loaded by Oracle JDK 8u301 as well as Open JDK 17 and openssl.


Code to reproduce error: https://gist.github.com/magnusvojbacke/51799be440240afc5235174ae30c7d1c

Run this class with openjdk 8u312 and get the following exception:
Error message:
Exception in thread "main" java.io.IOException: keystore password was incorrect
at sun.security.pkcs12.PKCS12KeyStore.engineLoad(PKCS12KeyStore.java:2079)
at java.security.KeyStore.load(KeyStore.java:1445)
at PkcsFail.main(PkcsFail.java:18)
Caused by: java.security.UnrecoverableKeyException: failed to decrypt safe contents entry: javax.crypto.BadPaddingException: Given final block not properly padded. Such issues can arise if a bad key is used during decryption.

Run with oracle jdk 8u301 or openjdk 17 and get the "Success" output.

This communication is confidential and is only intended for the use of the individual or entity to which it is directed. It may contain information that is privileged and exempt from disclosure under applicable law. If you are not the intended recipient please notify us immediately. You should not copy it or disclose its contents to any other person.

From alexey at azul.com  Tue Dec 14 12:19:17 2021
From: alexey at azul.com (Alexey Bakhtin)
Date: Tue, 14 Dec 2021 12:19:17 +0000
Subject: java.security.KeystStore fails to load some PKCS12 stores
In-Reply-To: <BD61FB3D-7670-439B-B2AA-E5386300909F@digitalroute.com>
References: <BD61FB3D-7670-439B-B2AA-E5386300909F@digitalroute.com>
Message-ID: <B5E0CAFB-A728-4939-B329-230CE14B8C67@azul.com>

Hi Magnus,

This issue can be fixed with backport of JDK-8076190
The patch is still under review: https://mail.openjdk.java.net/pipermail/jdk8u-dev/2021-September/014268.html

Regards
Alexey


> On 14 Dec 2021, at 14:51, Magnus Vojbacke <magnus.vojbacke at digitalroute.com> wrote:
> 
> We would like java.security.Keystore to be able to load all PKCS12 stores, like in Oracle JDK or the latest version of OpenJDK.
> 
> I would love to see an OpenJDK bug on this and subsequent fix for openjdk 8u. Currently, the OpenJDK 8u312 and 8u322(EA) fail to load some PKCS12 certificates. The same certificates can be loaded by Oracle JDK 8u301 as well as Open JDK 17 and openssl.
> 
> 
> Code to reproduce error: https://gist.github.com/magnusvojbacke/51799be440240afc5235174ae30c7d1c
> 
> Run this class with openjdk 8u312 and get the following exception:
> Error message:
> Exception in thread "main" java.io.IOException: keystore password was incorrect
> at sun.security.pkcs12.PKCS12KeyStore.engineLoad(PKCS12KeyStore.java:2079)
> at java.security.KeyStore.load(KeyStore.java:1445)
> at PkcsFail.main(PkcsFail.java:18)
> Caused by: java.security.UnrecoverableKeyException: failed to decrypt safe contents entry: javax.crypto.BadPaddingException: Given final block not properly padded. Such issues can arise if a bad key is used during decryption.
> 
> Run with oracle jdk 8u301 or openjdk 17 and get the "Success" output.
> 
> This communication is confidential and is only intended for the use of the individual or entity to which it is directed. It may contain information that is privileged and exempt from disclosure under applicable law. If you are not the intended recipient please notify us immediately. You should not copy it or disclose its contents to any other person.


From hohensee at amazon.com  Tue Dec 14 17:12:53 2021
From: hohensee at amazon.com (Hohensee, Paul)
Date: Tue, 14 Dec 2021 17:12:53 +0000
Subject: [8u] RFR 8266749: AArch64: Backtracing broken on PAC enabled
 systems
Message-ID: <2E456BE2-8488-4718-9D5C-47ABF2486524@amazon.com>

Got approval and pushed. Thanks, Alan.

Paul

From: Alan Hayward <Alan.Hayward at arm.com>
Date: Thursday, July 1, 2021 at 3:45 AM
To: "Hohensee, Paul" <hohensee at amazon.com>
Cc: "jdk8u-dev at openjdk.java.net" <jdk8u-dev at openjdk.java.net>, nd <nd at arm.com>
Subject: RE: [8u] RFR 8266749: AArch64: Backtracing broken on PAC enabled systems

Thanks.

I?ve now added the fix request to the bug (https://bugs.openjdk.java.net/browse/JDK-8266749)
I should have done that before.

Requesting approval and then sponser please.



Alan.


On 30 Jun 2021, at 17:37, Hohensee, Paul <hohensee at amazon.com<mailto:hohensee at amazon.com>> wrote:

Lgtm.

Thanks,
Paul

-----Original Message-----
From: jdk8u-dev <jdk8u-dev-retn at openjdk.java.net<mailto:jdk8u-dev-retn at openjdk.java.net>> on behalf of Alan Hayward <Alan.Hayward at arm.com<mailto:Alan.Hayward at arm.com>>
Date: Tuesday, June 29, 2021 at 2:34 AM
To: "jdk8u-dev at openjdk.java.net<mailto:jdk8u-dev at openjdk.java.net>" <jdk8u-dev at openjdk.java.net<mailto:jdk8u-dev at openjdk.java.net>>
Subject: [8u] RFR 8266749: AArch64: Backtracing broken on PAC enabled systems

Hi,
I?d like to backport this fix.

Webrev: http://cr.openjdk.java.net/~ahayward/8266749/webrev/

On fedora 33 (and onwards), openJDK is build with PAC enabled on Aarch64.
This patch is required to make the backtracking work.

Tested manually on Fedora 33 on a PAC system (VM on M1 Mac)

Applied cleanly from TIP version, except for
* Files moved into VM directories
* New Windows and Mac files removed from patch.

I also have an 11u version awaiting review here: https://github.com/openjdk/jdk11u-dev/pull/39


(First time using webrev and back porting, so apologies if I?ve missed something)


Thanks,
Alan.
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.


From felix.yang at huawei.com  Wed Dec 15 03:44:53 2021
From: felix.yang at huawei.com (Yangfei (Felix))
Date: Wed, 15 Dec 2021 03:44:53 +0000
Subject: RFR: 8233019: java.lang.Class.isPrimitive() (C1) returns wrong result
 if Klass* is aligned to 32bit
Message-ID: <737b6c3e9e84415e91a2a2a515eb8641@huawei.com>

Hi,

I see 8u backport for JDK-8150669 has been approved for [1]. 
Before pushing 8u backport for [1], I would like to get another reviewing for 8u fix for [2]. 
This resolves the corner case that leads to incorrect result for C1 intrinsic, so I think it will be safer to push these two fixes together to 8u. 

Original patch for 11u: https://hg.openjdk.java.net/jdk-updates/jdk11u-dev/rev/e1b6631cbd2f 
Patch does not apply cleanly to 8u: arm and s390 ports are not there and we don?t have c1 compiler support in ppc port in 8u. 

8u-backport patch based on [3]:
https://cr.openjdk.java.net/~dongbohe/8233019-8u/8233019-8u.diff 

Performed full jtreg test both on x86_64-linux-gnu and aarch64-linux-gnu platforms. 

Thanks,
Felix

[1] https://bugs.openjdk.java.net/browse/JDK-8150669 
[2] https://bugs.openjdk.java.net/browse/JDK-8233019 
[3] http://cr.openjdk.java.net/~fyang/8150669-8u/webrev.00 

From hedongbo at huawei.com  Fri Dec 17 01:35:06 2021
From: hedongbo at huawei.com (hedongbo)
Date: Fri, 17 Dec 2021 01:35:06 +0000
Subject: [8u] RFR: 8173361: various crashes in
 JvmtiExport::post_compiled_method_load
Message-ID: <4dd54b5a943842868ec4b1c8aed2dbf3@huawei.com>

Hi,

Please review the backport of JDK-8173361 to 8u.
Bug: https://bugs.openjdk.java.net/browse/JDK-8173361
11u commit: https://hg.openjdk.java.net/jdk-updates/jdk11u/rev/99bdef096320
8u webrev: https://cr.openjdk.java.net/~dongbohe/8173361/webrev.00/

This patch doesn't apply cleanly.
I turned NoSafepointVerifier to No_Safepoint_Verifier because JDK- 8146690[1] changed the naming convention.
I removed the mutexLocker.cpp changeset because JDK-8047290[2]  does not exist in 8.
I added the CLDClosure* to ServiceThread::oops_do because JDK- 8154580[3] does not exist in 8.

Tested with tier1. No regression in tests.
Follow-up fix JDK-8235218[4] is planned to be backported as well.

[1] https://bugs.openjdk.java.net/browse/JDK-8146690
[2] https://bugs.openjdk.java.net/browse/JDK-8047290
[3] https://bugs.openjdk.java.net/browse/JDK-8154580
[4] https://bugs.openjdk.java.net/browse/JDK-8235218


Thanks,

hedongbo





From zgu at redhat.com  Fri Dec 17 15:13:44 2021
From: zgu at redhat.com (Zhengyu Gu)
Date: Fri, 17 Dec 2021 10:13:44 -0500
Subject: [8u] RFR 8275811: Incorrect instance to dispose
Message-ID: <d7c5616a-5675-ff27-d783-7ed49dd6b48d@redhat.com>

I would like to backport this patch for parity with Oracle 8u331.

Bug: https://bugs.openjdk.java.net/browse/JDK-8275811
Patch: 
https://github.com/openjdk/jdk/commit/cddc6ce44695cba4614c3405eb2b194d7c76489b

The original patch does not apply cleanly to 8u. The only conflicts are 
in OutputRecord.java, due to line shifts. Resolved manually.

8u webrev: http://cr.openjdk.java.net/~zgu/JDK-8275811-8u/webrev.00/


Test:
   jdk_security

Thanks,

-Zhengyu


From apavlyutkin at azul.com  Mon Dec 20 09:00:53 2021
From: apavlyutkin at azul.com (Alexey Pavlyutkin)
Date: Mon, 20 Dec 2021 09:00:53 +0000
Subject: [8u] RFR 8190753: (zipfs): Accessing a large entry (> 2^31 bytes)
 leads to a negative initial size for ByteArrayOutputStream
In-Reply-To: <YbgNjUh8/TDYX8MF@hex.discworld.ac.uk>
References: <CH0PR11MB552330D2B65F5A08B0AA68D5C9629@CH0PR11MB5523.namprd11.prod.outlook.com>
 <af6738c9303f847a3c8b7a4aef59824c80aedfe6.camel@redhat.com>
 <CH0PR11MB5523A99FA95DA23124661EE5C9749@CH0PR11MB5523.namprd11.prod.outlook.com>
 <YbgNjUh8/TDYX8MF@hex.discworld.ac.uk>
Message-ID: <MWHPR11MB12480453EE9F31D460F4EB96C97B9@MWHPR11MB1248.namprd11.prod.outlook.com>

Hello Andrew,

I rebased the patch to monojdk8u.

The reason for the earlier occurrence of FileRolloverOutputStream is that there is some new code above in 11u. Particularly in 11u EntryOutputStream is being broken apart for the cases of deflating and RAW streaming with introduction of new DeflatingEntryOutputStream class.

The Map objects were fixed to be unmodifiable, accidental delta was eliminated.

The changes are available at

http://cr.openjdk.java.net/~yan/8190753/webrev.01/

I though the changes were already successfully reviewed. Sorry for that

Thank you

Regards,
Alex

-----Original Message-----
From: Andrew Hughes <gnu.andrew at redhat.com> 
Sent: Tuesday, December 14, 2021 6:21 AM
To: Alexey Pavlyutkin <apavlyutkin at azul.com>
Cc: Severin Gehwolf <sgehwolf at redhat.com>; jdk8u-dev at openjdk.java.net
Subject: Re: [8u] RFR 8190753: (zipfs): Accessing a large entry (> 2^31 bytes) leads to a negative initial size for ByteArrayOutputStream

On 20:42 Mon 13 Dec     , Alexey Pavlyutkin wrote:
> Hi Severin!
> 
> I have no idea. I did not do that advisedly. Probably I did them occasionally configuring jcheck tool. Anyway as I understand the changes are to be rebased to monorepo. Should I fix it before rebasing?
>

Please do.

There are some other issues with the patch:

* The placement of FileRolloverOutputStream seems to occur earlier in
  the 8u patch than in the 11u one. Can you confirm it ends up in the
  same or similar place in the file?

* Map.of creates unmodifiable Map instances. The replacement with emptyMap is fine, but the others need to be made unmodifiable. See the examples in jdk/test/sun/security/krb5/auto/KDC.java which was also converted from Map.of usage.

Please don't flag issues for approval with jdk8u-fix-request until they have been satisfactorily reviewed on the list.

> Thanks,
> Alex

Thanks,
--
Andrew :)
Pronouns: he / him or they / them
Senior Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222

From hedongbo at huawei.com  Tue Dec 21 06:34:48 2021
From: hedongbo at huawei.com (hedongbo)
Date: Tue, 21 Dec 2021 06:34:48 +0000
Subject: [8u] PRF:8202142 :jfr/event/io/TestInstrumentation is unstable
Message-ID: <471ccaa01db44300bc42e7a9e9ec0d2e@huawei.com>

Hi,

    Please review the backport of JDK-8202142 to 8u.
    Bug: https://bugs.openjdk.java.net/browse/JDK-8202142
    11u commit: https://github.com/openjdk/jdk11u-dev/commit/86c2995eae4b7ef57515445b9dd7505b6dc0bfa2
8u webrev: https://cr.openjdk.java.net/~dongbohe/8202142/webrev.00/

Patch does not apply cleanly: change to
ProblemList.txt is excluded (was added in JDK-8202142), paths reshuffled.

Testing: checked that TestInstrumentation.java fails without the patch
and passes with the patch.

Thanks,
hedongbo

From hedongbo at huawei.com  Tue Dec 21 06:38:48 2021
From: hedongbo at huawei.com (hedongbo)
Date: Tue, 21 Dec 2021 06:38:48 +0000
Subject: =?gb2312?B?s7e72DogWzh1XSBQUkY6ODIwMjE0MiA6amZyL2V2ZW50L2lvL1Rlc3RJbnN0?=
 =?gb2312?Q?rumentation_is_unstable?=
Message-ID: <084bbfe706fb4db0993b48afa6879005@huawei.com>

hedongbo ??????[8u] PRF:8202142 :jfr/event/io/TestInstrumentation is unstable??

From hedongbo at huawei.com  Tue Dec 21 06:41:50 2021
From: hedongbo at huawei.com (hedongbo)
Date: Tue, 21 Dec 2021 06:41:50 +0000
Subject: [8u] PRF:8202142 :jfr/event/io/TestInstrumentation is unstable 
Message-ID: <8b406e0cda364daaa6ddd53a7859f2f2@huawei.com>

Hi,

    Please review the backport of JDK-8202142 to 8u.
    Bug: https://bugs.openjdk.java.net/browse/JDK-8202142
    11u commit: https://github.com/openjdk/jdk11u-dev/commit/86c2995eae4b7ef57515445b9dd7505b6dc0bfa2
    8u webrev: https://cr.openjdk.java.net/~dongbohe/8202142/webrev.00/

    Patch does not apply cleanly: change to
    ProblemList.txt is excluded (was added in JDK-8199712), paths reshuffled.

    Testing: checked that TestInstrumentation.java fails without the patch
    and passes with the patch.


Thanks,
hedongbo

From sgehwolf at redhat.com  Wed Dec 22 10:14:39 2021
From: sgehwolf at redhat.com (Severin Gehwolf)
Date: Wed, 22 Dec 2021 11:14:39 +0100
Subject: [Ping?] [8u] RFR: 8210283:  Support git as an SCM alternative
 in the build
In-Reply-To: <018e4ec4ebaabd486047b9594da773887d53eee2.camel@redhat.com>
References: <018e4ec4ebaabd486047b9594da773887d53eee2.camel@redhat.com>
Message-ID: <001bf6943ff9fb504cb44a1cfdfaf8bb658ca2bb.camel@redhat.com>

On Fri, 2021-12-10 at 15:11 +0100, Severin Gehwolf wrote:
> Hi,
> 
> Please review this adaptation of the corresponding JDK 11 patch. The
> JDK 11u patch didn't apply because the build system is widely different
> between these two releases.
> 
> The main difference is make/common/MakeBase.gmk (JDK 8) vs
> make/SourceRevision.gmk (JDK 11). I've basically rewritten those parts
> of the patch. All the SCM handling in JDK 8 is in MakeBase.
> FindAllReposAbs isn't present in JDK 8u.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8210283
> webrev: https://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8210283/01/webrev/
> 
> Testing: "make --trace source-tips" on mercurial tree as well as
> ???????? the git mirror. $IMAGE_DIR/release file contains the SHA of
> ???????? the sources it was built from with 'git:' or 'hg:' prefixes.
> 
> Thoughts?

Anyone? When building from the git read-only mirror the "release" file
no longer includes the git sha it was built from without this fix.

Thanks,
Severin


From zgu at redhat.com  Wed Dec 22 16:41:06 2021
From: zgu at redhat.com (Zhengyu Gu)
Date: Wed, 22 Dec 2021 11:41:06 -0500
Subject: [8u] RFR 8266187: Memory leak in appendBootClassPath()
Message-ID: <d8ebd70b-8473-3aa7-3a35-cc66a4fd875e@redhat.com>

Backport this patch for parity with Oracle 8u331. It fixes a memory leak 
and risk is low,

Bug: https://bugs.openjdk.java.net/browse/JDK-8266187
Patch: 
https://github.com/openjdk/jdk/commit/aa90df6f51940a73f9aa078a32768855c8568034

The original patch does not apply cleanly. The conflict is copyright 
year line. Resolved manually.

8u webrev: http://cr.openjdk.java.net/~zgu/JDK-8266187-8u/webrev.00/

Thanks,

-Zhengyu


From gnu.andrew at redhat.com  Tue Dec 28 01:28:09 2021
From: gnu.andrew at redhat.com (Andrew Hughes)
Date: Tue, 28 Dec 2021 01:28:09 +0000
Subject: [FREEZE] 8u322 NOW FROZEN
Message-ID: <YcpoKaVtHAuthzzH@hex.discworld.ac.uk>

The release tree:

https://hg.openjdk.java.net/jdk8u/monojdk8u

is now frozen in preparation for release on or after 2022-01-18.

The final pre-release tag is jdk8u322-b05.

The final release tag will be no lower than jdk8u322-b06.

Thanks,
-- 
Andrew :)
Pronouns: he / him or they / them
Senior Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222

From hedongbo at huawei.com  Thu Dec 30 03:58:13 2021
From: hedongbo at huawei.com (hedongbo)
Date: Thu, 30 Dec 2021 03:58:13 +0000
Subject: [8u] RFR: 8173361: various crashes in
 JvmtiExport::post_compiled_method_load
In-Reply-To: <4dd54b5a943842868ec4b1c8aed2dbf3@huawei.com>
References: <4dd54b5a943842868ec4b1c8aed2dbf3@huawei.com>
Message-ID: <348b7a3fcfef4d66bb8f0a4c085e20d9@huawei.com>

This problem has affected the customer's use at present. Can anyone help to take a look? Thanks.

Thanks,
hedongbo

From: hedongbo
Sent: Friday, December 17, 2021 9:35 AM
To: jdk8u-dev <jdk8u-dev at openjdk.java.net>
Cc: 'serviceability-dev at openjdk.java.net' <serviceability-dev at openjdk.java.net>
Subject: [8u] RFR: 8173361: various crashes in JvmtiExport::post_compiled_method_load


Hi,

Please review the backport of JDK-8173361 to 8u.
Bug: https://bugs.openjdk.java.net/browse/JDK-8173361
11u commit: https://hg.openjdk.java.net/jdk-updates/jdk11u/rev/99bdef096320
8u webrev: https://cr.openjdk.java.net/~dongbohe/8173361/webrev.00/

This patch doesn't apply cleanly.
I turned NoSafepointVerifier to No_Safepoint_Verifier because JDK- 8146690[1] changed the naming convention.
I removed the mutexLocker.cpp changeset because JDK-8047290[2]  does not exist in 8.
I added the CLDClosure* to ServiceThread::oops_do because JDK- 8154580[3] does not exist in 8.

Tested with tier1. No regression in tests.
Follow-up fix JDK-8235218[4] is planned to be backported as well.

[1] https://bugs.openjdk.java.net/browse/JDK-8146690
[2] https://bugs.openjdk.java.net/browse/JDK-8047290
[3] https://bugs.openjdk.java.net/browse/JDK-8154580
[4] https://bugs.openjdk.java.net/browse/JDK-8235218


Thanks,

hedongbo