RFR: 8u backport of JDK-8211301 [macos] support full window content options
Severin Gehwolf
sgehwolf at redhat.com
Thu Feb 11 09:39:33 UTC 2021
Hi Andreas,
On Tue, 2021-02-09 at 12:17 +0100, Andreas Ahlenstorf wrote:
> Hi!
>
> The backport adds support for the two properties
>
> apple.awt.fullWindowContent
> apple.awt.transparentTitleBar
>
> that make the content view extend into the window's title bar on
> macOS. The 11u patch didn't apply cleanly to 8u, so I copied it over
> manually. I didn't have to make any material changes.
>
> Original CSR: https://bugs.openjdk.java.net/browse/JDK-8242566
> Backport bug: https://bugs.openjdk.java.net/browse/JDK-8211301
> Webrev:
> https://cr.openjdk.java.net/~sgehwolf/webrevs/aahlenstorf/JDK-8211301/01/webrev/
Only some minor things:
src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java
1 /*
2 * Copyright (c) 2011, 2021, Oracle and/or its affiliates. All rights reserved.
3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
The JDK 11 patch set the updated year to 2018, not 2021. Please keep
2018. The reason for this is to keep code bases in sync as much as
possible.
test/java/awt/Window/FullWindowContentTest/FullWindowContentTest.java
2 * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved.
Same with copyrights. JDK 11 patch had 2018 only. Not 2018, 2021.
I don't need to see another webrev for these.
What kind of testing have you done?
Thanks,
Severin
More information about the jdk8u-dev
mailing list