[8u] RFR: 8261766: [8u] hotspot needs to recognise cl.exe 19.16 to build with VS2017

[Dmitry Cherepanov]

Thanks for the review. I've flagged the bug for approval.

Dmitry

On 16.02.2021 05:54, Andrew Hughes wrote:
> On 20:54 Mon 15 Feb     , Dmitry Cherepanov wrote:
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8261766
>> 8u webrev: http://cr.openjdk.java.net/~dcherepanov/openjdk8u/8261766/webrev.v0/
>>
>> The patch updates the build scripts for 8u to recognise values for MSC_VER "1914", "1915" and "1916". This fixes building 8u with VS 2017 version 15.9 (cl.exe 19.16).
>>
>> Alternatively, this could be resolved by backport for https://bugs.openjdk.java.net/browse/JDK-8043492 (that removes COMPILER_NAME and its usage). The benefit of the proposed patch is that it's minimal/low-risk and is in line with how similar issues were resolved in 8u (https://bugs.openjdk.java.net/browse/JDK-8209359).
>>
>> Thanks,
>>
>> Dmitry
>>
> I agree that this patch is preferable. JDK-8043492 changes a lot of
> the build logic which I think is unnecessarily risky for the change
> required.
>
> Patch looks good to me. Please flag this for approval.
>
> Thanks,